* [Qemu-devel] QAPI design mistake: RockerPort member @speed shoud bi
@ 2017-08-04 15:03 Markus Armbruster
0 siblings, 0 replies; only message in thread
From: Markus Armbruster @ 2017-08-04 15:03 UTC (permalink / raw)
To: Scott Feldman, Jiri Pirko; +Cc: qemu-devel, Stefan Hajnoczi, Eric Blake
RockerPort member @speed is documented to be "in Mbps" (presumably
Megabits/second). It uses QAPI type 'uint32'.
This is inappropriate for QAPI/QMP. It should have been made plain
bits/second (no multiple), and maybe 'uint64'. As far as I can tell,
the QAPI part didn't get review from QAPI experts. Probably because it
wasn't cc'ed to them.
Too late to fix now, but let's not repeat the mistake.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-04 15:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-04 15:03 [Qemu-devel] QAPI design mistake: RockerPort member @speed shoud bi Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).