From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw6t4-0006E4-Ta for qemu-devel@nongnu.org; Fri, 29 Apr 2016 07:47:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw6st-0005Kp-9o for qemu-devel@nongnu.org; Fri, 29 Apr 2016 07:47:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw6st-0005HM-4w for qemu-devel@nongnu.org; Fri, 29 Apr 2016 07:46:59 -0400 From: Markus Armbruster References: <1461903820-3092-1-git-send-email-eblake@redhat.com> <1461903820-3092-3-git-send-email-eblake@redhat.com> Date: Fri, 29 Apr 2016 13:46:45 +0200 In-Reply-To: <1461903820-3092-3-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 28 Apr 2016 22:23:23 -0600") Message-ID: <87oa8s3ae2.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 02/18] qapi: Improve use of qmp/types.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth , Luiz Capitulino , famz@redhat.com, "Michael S. Tsirkin" Eric Blake writes: > 'qobject-json.h' is not a QObject subtype; include this file > directly in .c files that are using it, rather than abusing > qmp/types.h for that purpose. > > Meanwhile, for files that include a list of individual QObject > subtypes, it's easier to just use qmp/types.h for that purpose. I checked that this patch doesn't add any new dependencies to .d files. In general, I'm wary of headers including headers to save typing, because it invites including the kitchen sink, resulting in slow compiles. Not this patch's (or series') problem, though. > Signed-off-by: Eric Blake > Reviewed-by: Fam Zheng