From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zw4nk-0006FD-Qa
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 04:01:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zw4nh-0005sZ-JF
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 04:01:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40799)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zw4nh-0005sV-DZ
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 04:01:13 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1447126297-27239-3-git-send-email-liang.z.li@intel.com> (Liang
	Li's message of "Tue, 10 Nov 2015 11:31:37 +0800")
References: <1447126297-27239-1-git-send-email-liang.z.li@intel.com>
	<1447126297-27239-3-git-send-email-liang.z.li@intel.com>
Date: Tue, 10 Nov 2015 10:01:09 +0100
Message-ID: <87oaf28bze.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [v2 RESEND 2/2] configure: add options to config
	avx2
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liang Li <liang.z.li@intel.com>
Cc: amit.shah@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com

Liang Li <liang.z.li@intel.com> wrote:
> Add the '--enable-avx2' & '--disable-avx2' option so as to config
> the AVX2 instruction optimization.
>
> By default, avx2 optimization is enabled, if '--disable-avx2' is not
> set, configure will detect if the compiler can support AVX2 option,
> if yes, AVX2 optimization is eabled, else disabled.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> ---
>  configure | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/configure b/configure
> index 42e57c0..4d81be2 100755
> --- a/configure
> +++ b/configure
> @@ -310,6 +310,7 @@ smartcard=""
>  libusb=""
>  usb_redir=""
>  opengl=""
> +avx2="yes"
>  zlib="yes"
>  lzo=""
>  snappy=""
> @@ -1057,6 +1058,10 @@ for opt do
>    ;;
>    --enable-usb-redir) usb_redir="yes"
>    ;;
> +  --disable-avx2) avx2="no"
> +  ;;
> +  --enable-avx2) avx2="yes"
> +  ;;
>    --disable-zlib-test) zlib="no"
>    ;;
>    --disable-lzo) lzo="no"
> @@ -1373,6 +1378,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    smartcard       smartcard support (libcacard)
>    libusb          libusb (for usb passthrough)
>    usb-redir       usb network redirection support
> +  avx2            support of avx2 instruction
>    lzo             support of lzo compression library
>    snappy          support of snappy compression library
>    bzip2           support of bzip2 compression library
> @@ -1809,6 +1815,24 @@ EOF
>    fi
>  fi
>  
> +########################################
> +# avx2 check
> +
> +if test "$avx2" != "no" ; then
> +    cat > $TMPC << EOF
> +int main(void) { return 0; }
> +EOF
> +    if compile_prog "" "-mavx2" ; then
> +        avx2="yes"
> +    else
> +        avx2="no"

the else bit shouldn't be:

          if test "$avx2" = "yes"; then
              feature_not_found "avx2" "Your compiler don't support avx2"
          fi
          avx=2="no"

??
> +    fi
> +fi
> +
> +if test "$avx2" = "yes" ; then
> +    avx2_cflags=" -mavx2"
> +fi
> +
>  ##########################################
>  # zlib check
>  
> @@ -4782,6 +4806,7 @@ echo "libssh2 support   $libssh2"
>  echo "TPM passthrough   $tpm_passthrough"
>  echo "QOM debugging     $qom_cast_debug"
>  echo "vhdx              $vhdx"
> +echo "avx2 support      $avx2"
>  echo "lzo support       $lzo"
>  echo "snappy support    $snappy"
>  echo "bzip2 support     $bzip2"
> @@ -5166,6 +5191,10 @@ if test "$opengl" = "yes" ; then
>    echo "OPENGL_LIBS=$opengl_libs" >> $config_host_mak
>  fi
>  
> +if test "$avx2" = "yes" ; then
> +  echo "AVX2_CFLAGS=$avx2_cflags" >> $config_host_mak
> +fi
> +
>  if test "$lzo" = "yes" ; then
>    echo "CONFIG_LZO=y" >> $config_host_mak
>  fi