From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtaiN-0002m6-PP for qemu-devel@nongnu.org; Tue, 03 Nov 2015 07:29:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtaiK-0002ni-Jw for qemu-devel@nongnu.org; Tue, 03 Nov 2015 07:29:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtaiK-0002ne-Ew for qemu-devel@nongnu.org; Tue, 03 Nov 2015 07:29:24 -0500 From: Juan Quintela In-Reply-To: <1446449823-25049-3-git-send-email-liang.z.li@intel.com> (Liang Li's message of "Mon, 2 Nov 2015 15:37:01 +0800") References: <1446449823-25049-1-git-send-email-liang.z.li@intel.com> <1446449823-25049-3-git-send-email-liang.z.li@intel.com> Date: Tue, 03 Nov 2015 13:29:22 +0100 Message-ID: <87oafbz2ot.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [v2 RESEND 2/4] migration: rename qemu_savevm_state_cancel Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: amit.shah@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, yong.y.wang@intel.com Liang Li wrote: > The function qemu_savevm_state_cancel is called after the migration > in migration_thread, it seems strange to 'cancel' it after completion, > rename it to qemu_savevm_state_cleanup looks better. > > Signed-off-by: Liang Li Reviewed-by: Juan Quintela