From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37325)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Xz3j9-0004Qu-C7
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:24:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Xz3j4-0007EJ-I5
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:24:19 -0500
References: <1418298396-27089-1-git-send-email-dgilbert@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1418298396-27089-1-git-send-email-dgilbert@redhat.com>
Date: Thu, 11 Dec 2014 13:24:33 +0000
Message-ID: <87oaracoa6.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/1] Sort include/qemu/typedefs.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org


Dr. David Alan Gilbert (git) <dgilbert@redhat.com> writes:

> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Mainly to make it less likely to conflict during merges.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

I'm happy with the idea (having been adding stuff recently). However
have you:

a) checked for typedefs no longer used by the wider code base
b) audited for others using opaque types pulling in full definitions?

Otherwise:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Cheers,

-- 
Alex Bennée