From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzQbE-00014c-JP for qemu-devel@nongnu.org; Tue, 24 Jun 2014 09:17:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzQb6-000675-UV for qemu-devel@nongnu.org; Tue, 24 Jun 2014 09:17:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzQb6-00066x-MZ for qemu-devel@nongnu.org; Tue, 24 Jun 2014 09:17:16 -0400 From: Juan Quintela In-Reply-To: (Amit Shah's message of "Fri, 20 Jun 2014 18:56:07 +0530") References: Date: Tue, 24 Jun 2014 15:17:12 +0200 Message-ID: <87oaximopz.fsf@troll.troll> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 00/18] migration: add static analysis tool to check vmstate compat Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu list , Markus Armbruster , Alexander Graf , "Dr. David Alan Gilbert" , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= Amit Shah wrote: > Hello, > > v5: > - Add section / description name checking for matching names for > changed fields. This has the benefit of also getting rid of the > for loop in the lookup. However, for each section, like piix4_pm, > all the changes have to be in one group, as against them being in > different ones. That's still better than earlier where sections > were not checked. If my Python gets better, I might come up with a > way to improve on this as well. (Juan Quintela) > - Add more comments to the Python script > - Update help text to be more verbose - for qemu and for the script. > - Simplify the check_fields() function - lesser indentations Applied. Later, Juan.