From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wksal-0006go-38 for qemu-devel@nongnu.org; Thu, 15 May 2014 06:08:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wksag-0007ow-L1 for qemu-devel@nongnu.org; Thu, 15 May 2014 06:08:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wksag-0007op-Cz for qemu-devel@nongnu.org; Thu, 15 May 2014 06:08:42 -0400 From: Juan Quintela In-Reply-To: <53740DC0.4030905@linux.vnet.ibm.com> (Michael R. Hines's message of "Thu, 15 May 2014 08:43:44 +0800") References: <1396078745-5584-1-git-send-email-arei.gonglei@huawei.com> <533A0B67.6010308@linux.vnet.ibm.com> <33183CC9F5247A488A2544077AF19020815E739F@SZXEMA503-MBS.china.huawei.com> <53740DC0.4030905@linux.vnet.ibm.com> Date: Thu, 15 May 2014 12:08:26 +0200 Message-ID: <87oayz9wx1.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: "Huangweidong (C)" , "qemu-devel@nongnu.org" , "dgilbert@redhat.com" , "owasserm@redhat.com" , "Gonglei (Arei)" , "mrhines@us.ibm.com" , Moyuxiang , "pbonzini@redhat.com" "Michael R. Hines" wrote: > On 05/09/2014 12:25 PM, Gonglei (Arei) wrote: >> Hi, >> >>> -----Original Message----- >>> From: Michael R. Hines [mailto:mrhines@linux.vnet.ibm.com] >>> Sent: Tuesday, April 01, 2014 8:42 AM >>> To: Gonglei (Arei); qemu-devel@nongnu.org >>> Cc: Huangweidong (C); quintela@redhat.com; dgilbert@redhat.com; >>> owasserm@redhat.com; mrhines@us.ibm.com; Moyuxiang; >>> pbonzini@redhat.com >>> Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration >>> >>> On 03/29/2014 03:39 PM, arei.gonglei@huawei.com wrote: >>>> From: Mo Yuxiang >>>> >>>> If the networking break or there's something wrong with rdma >>>> device(ib0 with no IP) during rdma migration, the main_loop of >>>> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event >>>> to fix this bug. >>>> >>>> Signed-off-by: Mo Yuxiang >>>> Signed-off-by: Gonglei >>>> --- >>>> migration-rdma.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/migration-rdma.c b/migration-rdma.c >>>> index eeb4302..f60749b 100644 >>>> --- a/migration-rdma.c >>>> +++ b/migration-rdma.c >>>> @@ -949,6 +949,7 @@ route: >>>> ERROR(errp, "result not equal to event_addr_resolved %s", >>>> rdma_event_str(cm_event->event)); >>>> perror("rdma_resolve_addr"); >>>> + rdma_ack_cm_event(cm_event); >>>> ret = -EINVAL; >>>> goto err_resolve_get_addr; >>>> } >>> Reviewed-by: Michael R. Hines >>> >>> Good catch. =) That's an obvious bug. It looks like I need >>> to do a much better job of "kill -9" inside the regression >>> testing scripts - probably i should try killing the migration >>> prematurely at different periods just to be sure there are >>> no more places where the connection state is not getting >>> cleaned up...... >>> >>> - Michael >>> >> Michael, do you have a plan to pull this patch to master? Thanks. >> >> Best regards, >> -Gonglei >> > > Sorry for the late reply, but I'm not the maintainer for migration, > that's Juan > (I can only signoff on patches like everyone else =). > > I also have outstanding RDMA patches myself that have not yet been pulled. > > Would you mind pinging Juan for both of us? Pointer, please? I was waiting for Michael Reviewed-by from Michael. Later, Juan. > > - Michael > > - Michael