From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35132)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Vlkrf-0002ca-Nz
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 14:33:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VlkrY-0006M9-EH
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 14:33:35 -0500
Received: from mail-pd0-f178.google.com ([209.85.192.178]:61921)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VlkrY-0006M1-8N
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 14:33:28 -0500
Received: by mail-pd0-f178.google.com with SMTP id y10so10526232pdj.37
	for <qemu-devel@nongnu.org>; Wed, 27 Nov 2013 11:33:27 -0800 (PST)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <20131127094219.GA2884@dhcp-200-207.str.redhat.com>
References: <1385407736-13941-1-git-send-email-mreitz@redhat.com>
	<87vbzfrqhw.fsf@codemonkey.ws>
	<20131127094219.GA2884@dhcp-200-207.str.redhat.com>
Date: Wed, 27 Nov 2013 11:33:23 -0800
Message-ID: <87ob55fxmk.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse
	backing HD for sync=none
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

Kevin Wolf <kwolf@redhat.com> writes:

> Am 26.11.2013 um 19:02 hat Anthony Liguori geschrieben:
>> Max Reitz <mreitz@redhat.com> writes:
>> 
>> > This series fixes the drive-mirror blockjob in case of "none" sync mode
>> > to always use the old (current) image file as the backing file of the
>> > newly created mirrored file (in case of "absolute-paths" mode).
>> >
>> > It is rather important to get this into 1.7, as we will introduce an at
>> > least pretty strange API in case the original file is unbacked
>> > otherwise.
>> 
>> Kevin/Stefan?  Do we need this for 1.7?
>
> Yes, it would be good to pick it up in order to avoid changing the API
> in 1.8 (I guess we would do it anyway because the current behaviour
> doesn't make any sense and we'd call it bug fix, but libvirt would have
> to deal with it and better to do it right in the first release.)
>
> Do you want to pick it up yourself or should I send a pull request?

I'll pick it up.

Regards,

Anthony Liguori

>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
> Kevin