From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44947)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UtdbQ-0006l2-Nb
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 08:53:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UtdbO-0005hc-Am
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 08:53:08 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:52238)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UtdbO-0005gX-6J
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 08:53:06 -0400
Received: from /spool/local
	by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Mon, 1 Jul 2013 08:53:04 -0400
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <874ncezl0l.fsf@blackfin.pond.sub.org>
References: <1372342930-28684-1-git-send-email-armbru@redhat.com>
	<1372342930-28684-5-git-send-email-armbru@redhat.com>
	<51CD9188.8060203@redhat.com>
	<874nci40gk.fsf@blackfin.pond.sub.org>
	<20130701030856.GD1946@amosk.info>
	<87a9m6bszj.fsf@blackfin.pond.sub.org>
	<20130701090020.GC20061@amosk.info>
	<874ncezl0l.fsf@blackfin.pond.sub.org>
Date: Mon, 01 Jul 2013 07:52:27 -0500
Message-ID: <87obam4f3o.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member
	"memory" to "ringbuf"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Amos Kong <akong@redhat.com>
Cc: lilei@linux.vnet.ibm.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com

Markus Armbruster <armbru@redhat.com> writes:

> Amos Kong <akong@redhat.com> writes:
>
>> On Mon, Jul 01, 2013 at 10:10:40AM +0200, Markus Armbruster wrote:
>>> Amos Kong <akong@redhat.com> writes:
>>> 
>> The comment line in your patch doen't start with '#', it starts with
>> blank-space. If we want qapi.py to process it, we need to do strip()
>> first.
>
> Aha.  I agree with your reading of parse_schema().  However, I get
> exactly identical generated files with and without this comment.
>
> Michael, Anthony, can you explain why?
>
> Any particular reason for requiring comments to start in column 0?

I don't remember a particular reason.  Most likely an evolutionary
artifact.

Regards,

Anthony Liguori