From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UVRKb-0007rQ-0p
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 14:55:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UVRKV-0006K5-VI
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 14:55:44 -0400
Received: from mail-oa0-f46.google.com ([209.85.219.46]:65506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UVRKV-0006Jz-Qs
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 14:55:39 -0400
Received: by mail-oa0-f46.google.com with SMTP id k3so3182253oag.19
	for <qemu-devel@nongnu.org>; Thu, 25 Apr 2013 11:55:39 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <1366316544-1428-7-git-send-email-lersek@redhat.com>
References: <1366316544-1428-1-git-send-email-lersek@redhat.com>
	<1366316544-1428-7-git-send-email-lersek@redhat.com>
Date: Thu, 25 Apr 2013 13:55:36 -0500
Message-ID: <87obd2xwwn.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v4 6/7] hw/i386/pc.c: move
	IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>, mst@redhat.com, qemu-devel@nongnu.org

Laszlo Ersek <lersek@redhat.com> writes:

> From: Michael S. Tsirkin <mst@redhat.com>
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  include/hw/i386/apic.h |    2 ++
>  hw/i386/pc.c           |    2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/i386/apic.h b/include/hw/i386/apic.h
> index 1d48e02..edbb37f 100644
> --- a/include/hw/i386/apic.h
> +++ b/include/hw/i386/apic.h
> @@ -26,6 +26,8 @@ void apic_designate_bsp(DeviceState *d);
>  /* pc.c */
>  DeviceState *cpu_get_current_apic(void);
>  
> +#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> +
>  /* cpu.c */
>  bool cpu_is_bsp(X86CPU *cpu);
>  
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 3c12b55..8727489 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -73,8 +73,6 @@
>  #define FW_CFG_E820_TABLE (FW_CFG_ARCH_LOCAL + 3)
>  #define FW_CFG_HPET (FW_CFG_ARCH_LOCAL + 4)
>  
> -#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> -
>  #define E820_NR_ENTRIES		16
>  
>  struct e820_entry {
> -- 
> 1.7.1