From: Anthony Liguori <anthony@codemonkey.ws>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets
Date: Mon, 10 Sep 2012 18:00:54 -0500 [thread overview]
Message-ID: <87obldbhzt.fsf@codemonkey.ws> (raw)
In-Reply-To: <1347276441-28552-1-git-send-email-berrange@redhat.com>
"Daniel P. Berrange" <berrange@redhat.com> writes:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> Allow passing of '--target-list=' to configure to request that
> all targets are to be disabled. This allows for doing a very
> fast tools-only build of things like qemu-img, qemu-io, qemu-nbd.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> configure | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/configure b/configure
> index 75dc9da..472374e 100755
> --- a/configure
> +++ b/configure
> @@ -127,7 +127,7 @@ cc_i386=i386-pc-linux-gnu-gcc
> libs_qga=""
> debug_info="yes"
>
> -target_list=""
> +target_list="DEFAULT"
>
> # Default value for a variable defining feature "foo".
> # * foo="no" feature will only be used if --enable-foo arg is given
> @@ -1319,15 +1319,10 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
> exit 1
> fi
>
> -if test -z "$target_list" ; then
> - target_list="$default_target_list"
> -else
> - target_list=`echo "$target_list" | sed -e 's/,/ /g'`
> -fi
> -if test -z "$target_list" ; then
> - echo "No targets enabled"
> - exit 1
> +if test "$target_list" = "DEFAULT" ; then
> + target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
> fi
> +
> # see if system emulation was really requested
> case " $target_list " in
> *"-softmmu "*) softmmu=yes
> --
> 1.7.11.2
next prev parent reply other threads:[~2012-09-10 23:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 11:27 [Qemu-devel] [PATCH v2] Add ability to disable build of all targets Daniel P. Berrange
2012-09-10 23:00 ` Anthony Liguori [this message]
2012-09-11 18:56 ` Eduardo Habkost
2012-09-11 19:02 ` [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option Eduardo Habkost
2012-09-12 2:35 ` Peter Crosthwaite
2012-09-12 13:20 ` Laurent Desnogues
2012-09-14 12:53 ` Peter Maydell
2012-09-14 13:20 ` Anthony Liguori
2012-09-14 13:30 ` Daniel P. Berrange
2012-09-14 17:37 ` Stefan Weil
2012-09-12 11:24 ` [Qemu-devel] [PATCH v2] Add ability to disable build of all targets Laurent Desnogues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obldbhzt.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).