From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLgYY-0000E7-7P
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:51:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLgYT-0000Ap-G9
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:51:41 -0400
Received: from [199.232.76.173] (port=52949 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLgYT-0000Ah-Ba
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:51:37 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54371)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MLgYS-0006oe-SF
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:51:37 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5UGpae5007276
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 12:51:36 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5UGpZQP021089
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 12:51:35 -0400
Received: from pike.pond.sub.org (vpn-10-97.str.redhat.com [10.32.10.97])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5UGpY5B023801
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 12:51:34 -0400
Subject: Re: [Qemu-devel] [PATCH 6/8] qdev/pci: misc fixes.
References: <1246353962-32308-1-git-send-email-kraxel@redhat.com>
	<1246353962-32308-7-git-send-email-kraxel@redhat.com>
	<200906301225.23268.paul@codesourcery.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 30 Jun 2009 18:51:33 +0200
In-Reply-To: <200906301225.23268.paul@codesourcery.com> (Paul Brook's message
	of "Tue\, 30 Jun 2009 12\:25\:22 +0100")
Message-ID: <87ocs58y22.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Paul Brook <paul@codesourcery.com> writes:

> On Tuesday 30 June 2009, Gerd Hoffmann wrote:
>> -    register_savevm("PCIBUS", nbus++, 1, pcibus_save, pcibus_load, bus);
>> +    register_savevm("PCIBUS", bus->qbus.busnr, 1, pcibus_save,
>> pcibus_load, bus);
>
> This is wrong. In principle there may be many different PCI domains with 
> overlapping bus numbers.
>
> Paul

We don't support multiple PCI domains, so this is fine for now.  When we
do, we can simply prepend the 16 bit PCI domain number to the 8 bit PCI
bus number.