From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure
Date: Wed, 10 Jun 2009 00:06:27 +0200 [thread overview]
Message-ID: <87ocsxoye4.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <1244582792-30589-3-git-send-email-ehabkost@redhat.com> (Eduardo Habkost's message of "Tue\, 9 Jun 2009 18\:26\:32 -0300")
Eduardo Habkost <ehabkost@redhat.com> writes:
Hi Eduardo,
> Some glibc versions don't have utimensat() available, but have other xxxat()
> functions. Make a separated check for utimensat() to make sure we can compile
> linux-user against some older glibc versions.
Why didn't you take the patches available in this thread
http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01290.html ?
afaik, they can also be found in maemo's qemu git tree (and sent again
later to the mailing list)
[...]
> +#ifdef CONFIG_UTIMENSAT
> +
> +#ifdef TARGET_NR_utimensat
> +static int sys_utimensat(int dirfd, const char *pathname,
> + const struct timespec times[2], int flags)
> +{
> + return (utimensat(dirfd, pathname, times, flags));
> +}
As you'll see when reading the thread I mentionned, this is broken.
Regards,
Arnaud
next prev parent reply other threads:[~2009-06-09 22:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 21:26 [Qemu-devel] [PATCH 0/2] linux-user: fix build error against older glibcs Eduardo Habkost
2009-06-09 21:26 ` [Qemu-devel] [PATCH 1/2] linux-user/syscall.c: define _ATFILE_SOURCE Eduardo Habkost
2009-06-09 21:26 ` [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure Eduardo Habkost
2009-06-09 22:06 ` Arnaud Patard [this message]
2009-06-10 14:12 ` Eduardo Habkost
2009-06-10 14:39 ` Arnaud Patard
2009-06-10 19:10 ` Eduardo Habkost
2009-06-10 21:48 ` Riku Voipio
2009-06-10 22:09 ` Eduardo Habkost
2009-06-11 15:14 ` Riku Voipio
2009-06-10 16:07 ` Riku Voipio
2009-06-10 16:20 ` Glauber Costa
2009-06-10 16:30 ` Arnaud Patard
2009-06-10 16:56 ` Glauber Costa
2009-06-10 22:05 ` Riku Voipio
2009-06-11 8:33 ` Arnaud Patard
2009-06-11 15:09 ` Riku Voipio
2009-06-12 8:30 ` ltp vs linux-user (was: Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure) Arnaud Patard
2009-06-11 11:27 ` [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure vibi sreenivasan
2009-06-12 13:24 ` vibi sreenivasan
2009-06-10 15:03 ` Glauber Costa
2009-06-10 21:53 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocsxoye4.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=ehabkost@redhat.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).