From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ME9S7-0003f2-OZ
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 18:05:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ME9S5-0003dA-EZ
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 18:05:55 -0400
Received: from [199.232.76.173] (port=59020 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ME9S5-0003cu-7L
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 18:05:53 -0400
Received: from lechat.rtp-net.org ([88.191.19.38]:43147)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <arnaud.patard@rtp-net.org>) id 1ME9S4-0000wc-9E
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 18:05:52 -0400
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on
	configure
References: <1244582792-30589-1-git-send-email-ehabkost@redhat.com>
	<1244582792-30589-3-git-send-email-ehabkost@redhat.com>
Date: Wed, 10 Jun 2009 00:06:27 +0200
In-Reply-To: <1244582792-30589-3-git-send-email-ehabkost@redhat.com> (Eduardo
	Habkost's message of "Tue\, 9 Jun 2009 18\:26\:32 -0300")
Message-ID: <87ocsxoye4.fsf@lechat.rtp-net.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

Eduardo Habkost <ehabkost@redhat.com> writes:

Hi Eduardo,

> Some glibc versions don't have utimensat() available, but have other xxxat()
> functions. Make a separated check for utimensat() to make sure we can compile
> linux-user against some older glibc versions.

Why didn't you take the patches available in this thread
http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01290.html ?

afaik, they can also be found in maemo's qemu git tree (and sent again
later to the mailing list)

[...]

> +#ifdef CONFIG_UTIMENSAT
> +
> +#ifdef TARGET_NR_utimensat
> +static int sys_utimensat(int dirfd, const char *pathname,
> +    const struct timespec times[2], int flags)
> +{
> +  return (utimensat(dirfd, pathname, times, flags));
> +}

As you'll see when reading the thread I mentionned, this is broken.

Regards,
Arnaud