Re: [PULL v2 4/6] python: add qapi static analysis tests

[Markus Armbruster <armbru@redhat.com>]

John Snow <jsnow@redhat.com> writes:

> Update the python tests to also check QAPI and the QAPI Sphinx
> extensions. The docs/sphinx/qapidoc_legacy.py file is not included in
> these checks, as it is destined for removal soon. mypy is also not
> called on the QAPI Sphinx extensions, owing to difficulties supporting
> Sphinx 3.x - 8.x while maintaining static type checking support. mypy
> *is* called on all of the QAPI tools themselves, though.
>
> flake8, isort and mypy use the tool configuration from the existing
> python directory (in setup.cfg). pylint continues to use the special
> configuration located in scripts/qapi/ - that configuration is more
> permissive. If we wish to unify the two configurations, that's a
> separate series and a discussion for a later date.
>
> The list of pylint ignores is also updated, owing again to the wide
> window of pylint version support: newer versions require pragmas to
> occasionally silence the "too many positional arguments" warning, but
> older versions do not have such a warning category and will instead yelp
> about an unrecognized option. Silence that warning, too.
>
> As a result of this patch, one would be able to run any of the following
> tests locally from the qemu.git/python directory and have it cover the
> QAPI tooling as well. All of the following options run the python tests,
> static analysis tests, and linter checks; but with different
> combinations of dependencies and interpreters.
>
> - "make check-minreqs" Run tests specifically under our oldest supported
>   Python and our oldest supported dependencies. This is the test that
>   runs on GitLab as "check-python-minreqs". This helps ensure we do not
>   regress support on older platforms accidentally.
>
> - "make check-tox" Runs the tests under the newest supported
>   dependencies, but under each supported version of Python in turn. At
>   time of writing, this is Python 3.8 to 3.13 inclusive. This test helps

Missed this: it's 3.9 since

commit d64db833d6e3cbe9ea5f36342480f920f3675cea
Author: Thomas Huth <thuth@redhat.com>
Date:   Fri Apr 25 14:07:10 2025 +0200

    Drop support for Python 3.8
    
    Python 3.8 went "end of life" in October 2024 and Fedora 42 dropped
    this version already, so the "python" CI job is currently failing.
    Thus it's time to drop support for this Python version in QEMU, too.
    
    While we're at it, also look for "python3.13" in the configure script.
    
    Message-ID: <20250425120710.879518-1-thuth@redhat.com>
    Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
    Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: Thomas Huth <thuth@redhat.com>

Too late to adjust the commit message.  Is there anything else in need
of adjustment?

[...]