From: "Alex Bennée" <alex.bennee@linaro.org>
To: Julia <midnight@trainwit.ch>
Cc: "Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [PATCH 1/1] target/riscv: log guest errors when reserved bits are set in PTEs
Date: Mon, 03 Feb 2025 14:14:25 +0000 [thread overview]
Message-ID: <87pljzazem.fsf@draig.linaro.org> (raw)
In-Reply-To: <8149beba-66b1-4707-93f1-083b8bc5ece0@app.fastmail.com> (Julia's message of "Mon, 03 Feb 2025 18:12:21 +1100")
Julia <midnight@trainwit.ch> writes:
>> This happens because 'pte' is a 'target_ulong' type that, for riscv32, will be
>> interpreted as uint32_t while the FMT being used is PRIx64.
>>
>> You can fix it by using TARGET_FMT_lx instead of PRIx64:
>>
>
> I've sent a follow-up patch fixing these build errors, it builds on 32 & 64 bit on my system. Cheers
>
> As for the Signed-off-by, I'd rather not, and the contributing guide
> does not require it.
It absolutely does, as listed in the minimal checklist:
https://qemu.readthedocs.io/en/master/devel/submitting-a-patch.html#id30
>
> Regards,
> Julia
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2025-02-03 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-02 5:15 [PATCH 0/1] -----BEGIN SSH SIGNATURE----- julia
2025-02-02 5:15 ` [PATCH 1/1] target/riscv: log guest errors when reserved bits are set in PTEs julia
2025-02-02 22:04 ` Daniel Henrique Barboza
2025-02-03 7:12 ` Julia
2025-02-03 14:14 ` Alex Bennée [this message]
2025-02-03 14:15 ` Alex Bennée
2025-02-03 17:29 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pljzazem.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=dbarboza@ventanamicro.com \
--cc=midnight@trainwit.ch \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).