From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 153D0E732CA for ; Thu, 28 Sep 2023 13:02:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlqen-0005Az-4q; Thu, 28 Sep 2023 09:02:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlqeb-0004o8-CK for qemu-devel@nongnu.org; Thu, 28 Sep 2023 09:02:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlqeY-00029S-Af for qemu-devel@nongnu.org; Thu, 28 Sep 2023 09:02:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695906120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JFBJeQropeRJ1+MFEcUErkDO7v9yLkLjSDp67kIIMIk=; b=J7LeNCW7GhzN9wg4pBWs8XZM0//8NE60FwmaGIOEgY1C2QGYt7zs2tsdFR0NvWSeywsJyH gM1r2U7oqDLJ/bdBHBj2ti38Zuz3TGjFoMGMuFfy7RLGINW45fGOTN8OOpoGBq92CQwiQh MO9mLA37o2UNzqMzZOpRYhppPRd+v/s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-4xBJ8JNIMpa0GnKa8eltGQ-1; Thu, 28 Sep 2023 09:01:57 -0400 X-MC-Unique: 4xBJ8JNIMpa0GnKa8eltGQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0E56B101A53B; Thu, 28 Sep 2023 13:01:57 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF8A02026D4B; Thu, 28 Sep 2023 13:01:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CF11321E6900; Thu, 28 Sep 2023 15:01:55 +0200 (CEST) From: Markus Armbruster To: BALATON Zoltan Cc: Paolo Bonzini , qemu-devel@nongnu.org, mkletzan@redhat.com, vr_qemu@t-online.de Subject: Re: [PATCH 02/13] audio: Require AudioState in AUD_add_capture References: <20230923085507.399260-1-pbonzini@redhat.com> <20230923085507.399260-3-pbonzini@redhat.com> Date: Thu, 28 Sep 2023 15:01:55 +0200 In-Reply-To: (BALATON Zoltan's message of "Sat, 23 Sep 2023 13:48:54 +0200 (CEST)") Message-ID: <87pm221mf0.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org BALATON Zoltan writes: > On Sat, 23 Sep 2023, Paolo Bonzini wrote: >> From: Martin Kletzander >> >> Since all callers require a valid audiodev this function can now safely >> abort in case of missing AudioState. >> >> Signed-off-by: Martin Kletzander >> Message-ID: >> Signed-off-by: Paolo Bonzini >> --- >> audio/audio.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/audio/audio.c b/audio/audio.c >> index 90c7c49d116..42bfa330146 100644 >> --- a/audio/audio.c >> +++ b/audio/audio.c >> @@ -1876,10 +1876,9 @@ CaptureVoiceOut *AUD_add_capture( >> struct capture_callback *cb; >> >> if (!s) { >> - if (!legacy_config) { >> - dolog("Capturing without setting an audiodev is deprecated\n"); >> - } >> - s = audio_init(NULL, NULL); >> + error_setg(&error_abort, >> + "Capturing without setting an audiodev is not supported"); >> + abort(); > > This looks suspicious to me but I don't know if you can do this. Probably Markus can advise. I would use error_report and abort() or error_setg if you have an errp then return but this func doesn't seem to have errp. Missed this until now; my apologies. qapi/error.h: * Please don't error_setg(&error_fatal, ...), use error_report() and * exit(), because that's more obvious. * Likewise, don't error_setg(&error_abort, ...), use assert().