From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Laurent Vivier" <lvivier@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Helge Deller" <deller@gmx.de>,
"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Juan Quintela" <quintela@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Cédric Le Goater" <clg@kaod.org>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Andrew Jeffery" <andrew@aj.id.au>,
qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-arm@nongnu.org,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Beraldo Leal" <bleal@redhat.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"David Hildenbrand" <david@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Song Gao" <gaosong@loongson.cn>, "Joel Stanley" <joel@jms.id.au>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>
Subject: Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine
Date: Thu, 04 May 2023 08:09:17 +0100 [thread overview]
Message-ID: <87pm7gsh9q.fsf@linaro.org> (raw)
In-Reply-To: <6ed176f9-be38-b4ea-ac90-906cc62c24c4@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 03/05/2023 20.32, Peter Maydell wrote:
>> On Wed, 3 May 2023 at 18:06, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>
>>> On 5/3/23 17:35, Alex Bennée wrote:
>>>>> You should select a device only if you cannot even start
>>>>> the machine without --nodefaults.
>>>>
>>>> Which is the case here right? We could skip tests that explicitly
>>>> instantiate a device but these are tests failing with default devices
>>>> the machine tries to instantiate.
>>>
>>> I'm sorry, I meant "select" directives are needed if you cannot even
>>> start the machine *with* --nodefaults.
>>>
>>> Devices that are added *without* --nodefaults should use "imply"
>>> directives instead, as is already the case.
>> Do we really want to build a QEMU that then barfs unless
>> you pass -nodefaults, though ? That doesn't seem very useful.
>> Something somewhere ought to be saying "if you want the
>> virt board then you almost certainly want these". Or
>> alternatively we should fall back to "don't create a
>> network device we don't have", maybe ?
>
> I think we should do the latter. If you compiled without certain
> devices that are used only in the default mode, the board should not
> try to instantiate such devices (since it is also working fine without
> them). Just my 0.02 €.
So I hand hacked qtest_spawn_qemu with:
va_start(ap, fmt);
g_string_append_printf(command, CMD_EXEC "%s %s -nodefaults ",qtest_qemu_binary(), tracearg);
g_string_append_vprintf(command, fmt, ap);
va_end(ap);
And the following tests fail on the --no-default-devices
--no-default-features build:
18/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/qom-test ERROR 51.23s killed by signal 6 SIGABRT
37/436 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test ERROR 0.20s killed by signal 6 SIGABRT
55/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/test-hmp ERROR 50.24s killed by signal 6 SIGABRT
94/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/qos-test ERROR 50.19s killed by signal 6 SIGABRT
103/436 qemu:qtest+qtest-sparc64 / qtest-sparc64/prom-env-test ERROR 608.02s killed by signal 6 SIGABRT
115/436 qemu:qtest+qtest-aarch64 / qtest-aarch64/cdrom-test ERROR 0.31s killed by signal 6 SIGABRT
122/436 qemu:qtest+qtest-alpha / qtest-alpha/test-filter-mirror ERROR 0.16s killed by signal 6 SIGABRT
123/436 qemu:qtest+qtest-alpha / qtest-alpha/test-filter-redirector ERROR 0.16s killed by signal 6 SIGABRT
132/436 qemu:qtest+qtest-arm / qtest-arm/pflash-cfi02-test ERROR 50.28s killed by signal 6 SIGABRT
134/436 qemu:qtest+qtest-arm / qtest-arm/microbit-test ERROR 51.02s killed by signal 6 SIGABRT
135/436 qemu:qtest+qtest-arm / qtest-arm/test-arm-mptimer ERROR 51.20s killed by signal 6 SIGABRT
136/436 qemu:qtest+qtest-arm / qtest-arm/cdrom-test ERROR 0.31s killed by signal 6 SIGABRT
157/436 qemu:qtest+qtest-hppa / qtest-hppa/test-filter-mirror ERROR 0.16s killed by signal 6 SIGABRT
158/436 qemu:qtest+qtest-hppa / qtest-hppa/test-filter-redirector ERROR 0.26s killed by signal 6 SIGABRT
167/436 qemu:qtest+qtest-i386 / qtest-i386/test-filter-mirror ERROR 0.17s killed by signal 6 SIGABRT
168/436 qemu:qtest+qtest-i386 / qtest-i386/test-filter-redirector ERROR 0.17s killed by signal 6 SIGABRT
169/436 qemu:qtest+qtest-i386 / qtest-i386/ipmi-bt-test ERROR 0.17s killed by signal 6 SIGABRT
171/436 qemu:qtest+qtest-i386 / qtest-i386/usb-hcd-uhci-test ERROR 0.17s killed by signal 6 SIGABRT
172/436 qemu:qtest+qtest-i386 / qtest-i386/usb-hcd-ehci-test ERROR 0.17s killed by signal 6 SIGABRT
173/436 qemu:qtest+qtest-i386 / qtest-i386/rtl8139-test ERROR 0.17s killed by signal 6 SIGABRT
192/436 qemu:qtest+qtest-i386 / qtest-i386/cdrom-test ERROR 0.65s killed by signal 6 SIGABRT
197/436 qemu:qtest+qtest-i386 / qtest-i386/readconfig-test ERROR 0.41s killed by signal 6 SIGABRT
287/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/test-filter-mirror ERROR 51.44s killed by signal 6 SIGABRT
288/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/test-filter-redirector ERROR 51.20s killed by signal 6 SIGABRT
289/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/m48t59-test ERROR 51.20s killed by signal 6 SIGABRT
290/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/boot-order-test ERROR 51.19s killed by signal 6 SIGABRT
291/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/device-plug-test ERROR 51.20s killed by signal 6 SIGABRT
292/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/pnv-xscom-test ERROR 51.20s killed by signal 6 SIGABRT
293/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/rtas-test ERROR 51.20s killed by signal 6 SIGABRT
294/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/usb-hcd-uhci-test ERROR 51.20s killed by signal 6 SIGABRT
295/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/display-vga-test ERROR 51.21s killed by signal 6 SIGABRT
296/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/numa-test ERROR 51.19s killed by signal 6 SIGABRT
297/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/cpu-plug-test ERROR 51.20s killed by signal 6 SIGABRT
298/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/drive_del-test ERROR 51.20s killed by signal 6 SIGABRT
299/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/cdrom-test ERROR 51.20s killed by signal 6 SIGABRT
300/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/device-introspect-test ERROR 51.20s killed by signal 6 SIGABRT
301/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/machine-none-test ERROR 51.20s killed by signal 6 SIGABRT
302/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/qmp-test ERROR 51.20s killed by signal 6 SIGABRT
303/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/qmp-cmd-test ERROR 51.19s killed by signal 6 SIGABRT
304/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/readconfig-test ERROR 51.20s killed by signal 6 SIGABRT
305/436 qemu:qtest+qtest-ppc64 / qtest-ppc64/netdev-socket ERROR 51.20s killed by signal 6 SIGABRT
306/436 qemu:qtest+qtest-ppc / qtest-ppc/test-filter-mirror ERROR 0.17s killed by signal 6 SIGABRT
307/436 qemu:qtest+qtest-ppc / qtest-ppc/test-filter-redirector
ERROR 0.17s killed by signal 6 SIGABRT
338/436 qemu:qtest+qtest-s390x / qtest-s390x/test-filter-mirror ERROR 0.32s killed by signal 6 SIGABRT
339/436 qemu:qtest+qtest-s390x / qtest-s390x/test-filter-redirector ERROR 0.43s killed by signal 6 SIGABRT
341/436 qemu:qtest+qtest-s390x / qtest-s390x/device-plug-test ERROR 0.28s killed by signal 6 SIGABRT
342/436 qemu:qtest+qtest-s390x / qtest-s390x/virtio-ccw-test ERROR 0.16s killed by signal 6 SIGABRT
344/436 qemu:qtest+qtest-s390x / qtest-s390x/cdrom-test ERROR 0.30s killed by signal 6 SIGABRT
365/436 qemu:qtest+qtest-sparc64 / qtest-sparc64/test-filter-mirror ERROR 0.33s killed by signal 6 SIGABRT
366/436 qemu:qtest+qtest-sparc64 / qtest-sparc64/test-filter-redirector ERROR 0.32s killed by signal 6 SIGABRT
391/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/test-filter-mirror ERROR 0.16s killed by signal 6 SIGABRT
392/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/test-filter-redirector ERROR 0.17s killed by signal 6 SIGABRT
393/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/ipmi-bt-test ERROR 0.17s killed by signal 6 SIGABRT
395/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/usb-hcd-uhci-test ERROR 0.18s killed by signal 6 SIGABRT
396/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/usb-hcd-ehci-test ERROR 0.16s killed by signal 6 SIGABRT
397/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/rtl8139-test ERROR 0.17s killed by signal 6 SIGABRT
416/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/cdrom-test ERROR 0.66s killed by signal 6 SIGABRT
421/436 qemu:qtest+qtest-x86_64 / qtest-x86_64/readconfig-test ERROR 0.40s killed by signal 6 SIGABRT
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-05-04 7:11 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:12 [PATCH 00/22] testing/next: cirrus, docker, docs, ci, configs, gitlab Alex Bennée
2023-05-03 9:12 ` [PATCH 01/22] gitlab/cirrus: reduce scope of the FreeBSD testing matrix Alex Bennée
2023-05-03 9:18 ` Thomas Huth
2023-05-03 9:12 ` [PATCH 02/22] tests/docker: bump the xtensa base to debian:11-slim Alex Bennée
2023-05-03 9:20 ` Thomas Huth
2023-05-03 10:28 ` Juan Quintela
2023-05-03 9:12 ` [PATCH 03/22] docs: document breakpoint and watchpoint support Alex Bennée
2023-05-03 10:30 ` Juan Quintela
2023-05-03 9:12 ` [PATCH 04/22] scripts/ci: add gitlab-runner to kvm group Alex Bennée
2023-05-03 9:22 ` Thomas Huth
2023-05-03 10:15 ` Richard Henderson
2023-05-03 9:12 ` [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine Alex Bennée
2023-05-03 10:17 ` Richard Henderson
2023-05-03 14:00 ` Paolo Bonzini
2023-05-03 14:46 ` Fabiano Rosas
2023-05-03 15:35 ` Alex Bennée
2023-05-03 17:05 ` Paolo Bonzini
2023-05-03 18:32 ` Peter Maydell
2023-05-04 6:56 ` Thomas Huth
2023-05-04 7:09 ` Alex Bennée [this message]
2023-05-04 7:16 ` Paolo Bonzini
2023-05-04 12:56 ` Fabiano Rosas
2023-05-08 22:23 ` Paolo Bonzini
2023-05-09 9:27 ` Peter Maydell
2023-05-09 9:42 ` Paolo Bonzini
2023-05-09 10:00 ` Peter Maydell
2023-05-09 10:53 ` Paolo Bonzini
2023-05-09 11:37 ` Alex Bennée
2023-05-09 11:59 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 06/22] hw/arm: Select VIRTIO_BLK " Alex Bennée
2023-05-03 10:17 ` Richard Henderson
2023-05-03 10:31 ` Juan Quintela
2023-05-03 17:21 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 07/22] hw/arm: Select XLNX_USB_SUBSYS for xlnx-zcu102 machine Alex Bennée
2023-05-03 10:18 ` Richard Henderson
2023-05-03 17:07 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 08/22] hw/arm: Select GICV3_TCG for sbsa-ref machine Alex Bennée
2023-05-03 10:19 ` Richard Henderson
2023-05-03 17:22 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 09/22] hw/arm: Select e1000e " Alex Bennée
2023-05-03 10:20 ` Richard Henderson
2023-05-03 17:13 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 10/22] hw/arm: Select VGA_PCI " Alex Bennée
2023-05-03 10:21 ` Richard Henderson
2023-05-03 9:12 ` [PATCH 11/22] hw/alpha: make E1000_PCI a hard dependency for clipper Alex Bennée
2023-05-03 10:26 ` Richard Henderson
2023-05-03 17:14 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 12/22] hw/hppa: add TULIP as a dependency for HPPA_B160L Alex Bennée
2023-05-03 10:26 ` Richard Henderson
2023-05-03 17:15 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 13/22] hw/sparc: add a TCX dependency for SUN4M machines Alex Bennée
2023-05-03 10:27 ` Richard Henderson
2023-05-03 17:17 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 14/22] hw/loongarch: add VIRTIO as a dependency for LOONGARCH_VIRT Alex Bennée
2023-05-03 10:27 ` Richard Henderson
2023-05-03 17:18 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 15/22] hw/sh4: make RTL8139 a hard dependency for RD2 Alex Bennée
2023-05-03 10:27 ` Richard Henderson
2023-05-03 17:19 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 16/22] hw/mips: add VIRTIO and USB dependencies for LOONGSON3V Alex Bennée
2023-05-03 17:20 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT Alex Bennée
2023-05-03 10:28 ` Richard Henderson
2023-05-03 14:14 ` Max Filippov
2023-05-03 17:20 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 18/22] scripts/ci: clean-up the 20.04/22.04 confusion in ansible Alex Bennée
2023-05-03 9:12 ` [PATCH 19/22] gitlab: add ubuntu-22.04-aarch64-without-defaults Alex Bennée
2023-05-03 9:34 ` Thomas Huth
2023-05-03 10:29 ` Richard Henderson
2023-05-03 9:12 ` [PATCH 20/22] gitlab: enable minimal device profoile for aarch64 --disable-tcg Alex Bennée
2023-05-03 10:30 ` Richard Henderson
2023-05-03 10:34 ` Juan Quintela
2023-05-03 13:01 ` Fabiano Rosas
2023-05-03 9:12 ` [PATCH 21/22] tests/avocado: use http for mipsdistros.mips.com Alex Bennée
2023-05-03 9:43 ` Thomas Huth
2023-05-03 10:31 ` Richard Henderson
2023-05-10 7:12 ` Jiaxun Yang
2023-05-03 9:12 ` [PATCH 22/22] tests/qtest: skip bcm2835-test if no raspi3b model Alex Bennée
2023-05-03 9:51 ` Thomas Huth
2023-05-03 10:34 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm7gsh9q.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=andrew@aj.id.au \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=gaosong@loongson.cn \
--cc=iii@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=quintela@redhat.com \
--cc=rad@semihalf.com \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=yangxiaojuan@loongson.cn \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).