From: Juan Quintela <quintela@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
michael.roth@amd.com, armbru@redhat.com, eblake@redhat.com,
jasowang@redhat.com, zhanghailiang@xfusion.com,
philmd@linaro.org, thuth@redhat.com, berrange@redhat.com,
marcandre.lureau@redhat.com, pbonzini@redhat.com,
dave@treblig.org, hreitz@redhat.com, kwolf@redhat.com,
chen.zhang@intel.com, lizhijian@fujitsu.com
Subject: Re: [PATCH v2 1/4] block/meson.build: prefer positive condition for replication
Date: Thu, 20 Apr 2023 11:51:34 +0200 [thread overview]
Message-ID: <87pm7yzxsp.fsf@secure.mitica> (raw)
In-Reply-To: <20230419225232.508121-2-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Thu, 20 Apr 2023 01:52:29 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> ---
> block/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/meson.build b/block/meson.build
> index 382bec0e7d..b9a72e219b 100644
> --- a/block/meson.build
> +++ b/block/meson.build
> @@ -84,7 +84,7 @@ block_ss.add(when: 'CONFIG_WIN32', if_true: files('file-win32.c', 'win32-aio.c')
> block_ss.add(when: 'CONFIG_POSIX', if_true: [files('file-posix.c'), coref, iokit])
> block_ss.add(when: libiscsi, if_true: files('iscsi-opts.c'))
> block_ss.add(when: 'CONFIG_LINUX', if_true: files('nvme.c'))
> -if not get_option('replication').disabled()
> +if get_option('replication').allowed()
> block_ss.add(files('replication.c'))
> endif
> block_ss.add(when: libaio, if_true: files('linux-aio.c'))
next prev parent reply other threads:[~2023-04-20 9:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 22:52 [PATCH v2 0/4] COLO: improve build options Vladimir Sementsov-Ogievskiy
2023-04-19 22:52 ` [PATCH v2 1/4] block/meson.build: prefer positive condition for replication Vladimir Sementsov-Ogievskiy
2023-04-20 9:51 ` Juan Quintela [this message]
2023-04-20 13:47 ` Philippe Mathieu-Daudé
2023-04-19 22:52 ` [PATCH v2 2/4] scripts/qapi: allow optional experimental enum values Vladimir Sementsov-Ogievskiy
2023-04-20 9:55 ` Juan Quintela
2023-04-20 14:43 ` Eric Blake
2023-04-20 16:47 ` Vladimir Sementsov-Ogievskiy
2023-04-19 22:52 ` [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION Vladimir Sementsov-Ogievskiy
2023-04-20 10:03 ` Juan Quintela
2023-04-20 11:40 ` Vladimir Sementsov-Ogievskiy
2023-04-20 11:56 ` Juan Quintela
2023-04-20 21:08 ` Dr. David Alan Gilbert
2023-04-21 3:02 ` Zhang, Chen
2023-04-21 8:35 ` Vladimir Sementsov-Ogievskiy
2023-04-23 1:54 ` Zhang, Chen
2023-04-27 19:31 ` Vladimir Sementsov-Ogievskiy
2023-04-28 6:52 ` Juan Quintela
2023-04-19 22:52 ` [PATCH v2 4/4] configure: add --disable-colo-filters option Vladimir Sementsov-Ogievskiy
2023-04-20 9:09 ` Zhang, Chen
2023-04-20 10:09 ` Lukas Straub
2023-04-20 11:25 ` Vladimir Sementsov-Ogievskiy
2023-04-21 2:22 ` Zhang, Chen
2023-04-21 8:52 ` Vladimir Sementsov-Ogievskiy
2023-04-23 2:05 ` Zhang, Chen
2023-04-20 8:33 ` [PATCH v2 0/4] COLO: improve build options Lukas Straub
2023-04-20 8:39 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm7yzxsp.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=chen.zhang@intel.com \
--cc=dave@treblig.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).