* [PATCH] tests/avocado: add machine:none tag to version.py
@ 2022-12-15 22:47 Fabiano Rosas
2023-01-09 14:41 ` Fabiano Rosas
2023-01-09 15:42 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Fabiano Rosas @ 2022-12-15 22:47 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-arm, Peter Maydell, Philippe Mathieu-Daudé,
Alex Bennée, Cleber Rosa, Wainer dos Santos Moschetta,
Beraldo Leal
This test currently fails when run on a host for which the QEMU target
has no default machine set:
ERROR| Output: qemu-system-aarch64: No machine specified, and there is
no default
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
tests/avocado/version.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/avocado/version.py b/tests/avocado/version.py
index ded7f039c1..dd775955eb 100644
--- a/tests/avocado/version.py
+++ b/tests/avocado/version.py
@@ -15,6 +15,7 @@
class Version(QemuSystemTest):
"""
:avocado: tags=quick
+ :avocado: tags=machine:none
"""
def test_qmp_human_info_version(self):
self.vm.add_args('-nodefaults')
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado: add machine:none tag to version.py
2022-12-15 22:47 [PATCH] tests/avocado: add machine:none tag to version.py Fabiano Rosas
@ 2023-01-09 14:41 ` Fabiano Rosas
2023-01-09 15:42 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Fabiano Rosas @ 2023-01-09 14:41 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-arm, Peter Maydell, Philippe Mathieu-Daudé,
Alex Bennée, Cleber Rosa, Wainer dos Santos Moschetta,
Beraldo Leal
Fabiano Rosas <farosas@suse.de> writes:
> This test currently fails when run on a host for which the QEMU target
> has no default machine set:
>
> ERROR| Output: qemu-system-aarch64: No machine specified, and there is
> no default
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/avocado/version.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/avocado/version.py b/tests/avocado/version.py
> index ded7f039c1..dd775955eb 100644
> --- a/tests/avocado/version.py
> +++ b/tests/avocado/version.py
> @@ -15,6 +15,7 @@
> class Version(QemuSystemTest):
> """
> :avocado: tags=quick
> + :avocado: tags=machine:none
> """
> def test_qmp_human_info_version(self):
> self.vm.add_args('-nodefaults')
Ping
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado: add machine:none tag to version.py
2022-12-15 22:47 [PATCH] tests/avocado: add machine:none tag to version.py Fabiano Rosas
2023-01-09 14:41 ` Fabiano Rosas
@ 2023-01-09 15:42 ` Philippe Mathieu-Daudé
2023-01-09 16:42 ` Fabiano Rosas
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-09 15:42 UTC (permalink / raw)
To: Fabiano Rosas, qemu-devel
Cc: qemu-arm, Peter Maydell, Alex Bennée, Cleber Rosa,
Wainer dos Santos Moschetta, Beraldo Leal
On 15/12/22 23:47, Fabiano Rosas wrote:
> This test currently fails when run on a host for which the QEMU target
> has no default machine set:
>
> ERROR| Output: qemu-system-aarch64: No machine specified, and there is
> no default
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/avocado/version.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/avocado/version.py b/tests/avocado/version.py
> index ded7f039c1..dd775955eb 100644
> --- a/tests/avocado/version.py
> +++ b/tests/avocado/version.py
> @@ -15,6 +15,7 @@
> class Version(QemuSystemTest):
> """
> :avocado: tags=quick
> + :avocado: tags=machine:none
> """
> def test_qmp_human_info_version(self):
> self.vm.add_args('-nodefaults')
Looking at previous attempt in
https://lore.kernel.org/qemu-devel/20220104122104.849084-1-alex.bennee@linaro.org/
* tests/avocado/empty_cpu_model.py
Forced via vm.add_args('-machine', 'none')
tags=machine:none would be cleaner.
* tests/avocado/info_usernet.py and
* tests/avocado/vnc.py
-> Fixed by 5104b73824 ("tests/avocado: set -machine none
for userfwd and vnc tests")
* tests/avocado/version.py
-> This patch
* tests/avocado/migration.py
=> Missing
Maybe we can squash to this patch?
Meanwhile:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado: add machine:none tag to version.py
2023-01-09 15:42 ` Philippe Mathieu-Daudé
@ 2023-01-09 16:42 ` Fabiano Rosas
0 siblings, 0 replies; 4+ messages in thread
From: Fabiano Rosas @ 2023-01-09 16:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-arm, Peter Maydell, Alex Bennée, Cleber Rosa,
Wainer dos Santos Moschetta, Beraldo Leal
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 15/12/22 23:47, Fabiano Rosas wrote:
>> This test currently fails when run on a host for which the QEMU target
>> has no default machine set:
>>
>> ERROR| Output: qemu-system-aarch64: No machine specified, and there is
>> no default
>>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>> tests/avocado/version.py | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/avocado/version.py b/tests/avocado/version.py
>> index ded7f039c1..dd775955eb 100644
>> --- a/tests/avocado/version.py
>> +++ b/tests/avocado/version.py
>> @@ -15,6 +15,7 @@
>> class Version(QemuSystemTest):
>> """
>> :avocado: tags=quick
>> + :avocado: tags=machine:none
>> """
>> def test_qmp_human_info_version(self):
>> self.vm.add_args('-nodefaults')
>
> Looking at previous attempt in
> https://lore.kernel.org/qemu-devel/20220104122104.849084-1-alex.bennee@linaro.org/
>
> * tests/avocado/empty_cpu_model.py
>
> Forced via vm.add_args('-machine', 'none')
>
> tags=machine:none would be cleaner.
>
> * tests/avocado/info_usernet.py and
> * tests/avocado/vnc.py
>
> -> Fixed by 5104b73824 ("tests/avocado: set -machine none
> for userfwd and vnc tests")
>
> * tests/avocado/version.py
>
> -> This patch
>
> * tests/avocado/migration.py
>
> => Missing
I think the migration test is a bit harder because the machine type
would probably influnce the test. We would have to find a way to
specificy the different -machine options for each architecture. Or a way
of saying "use default machine, except for arm".
>
> Maybe we can squash to this patch?
>
> Meanwhile:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-09 16:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 22:47 [PATCH] tests/avocado: add machine:none tag to version.py Fabiano Rosas
2023-01-09 14:41 ` Fabiano Rosas
2023-01-09 15:42 ` Philippe Mathieu-Daudé
2023-01-09 16:42 ` Fabiano Rosas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).