From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 576D0C433FE for ; Fri, 21 Oct 2022 05:56:17 +0000 (UTC) Received: from localhost ([::1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oll0y-0008DN-AO for qemu-devel@archiver.kernel.org; Fri, 21 Oct 2022 01:56:16 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olkuE-0006a3-KX for qemu-devel@archiver.kernel.org; Fri, 21 Oct 2022 01:49:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olku4-0006KP-Gl for qemu-devel@nongnu.org; Fri, 21 Oct 2022 01:49:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olku2-0005Qn-QC for qemu-devel@nongnu.org; Fri, 21 Oct 2022 01:49:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666331345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QBX5KiLXbX7P8P3a+cVBh7Xtwe9pVLfUZQSamsMuzpw=; b=LF0NIm/57hDEF+T7TVMxv+bKmkGY6rzVlVkSOf6eSWJCQu/RE3qZTfySGFHuC2BDQhIInO NYMSKUGkG58G75RMsBplRqwN+uDMiuk4RSz/txZgga0EsYS6vJK7E5baJA5OtYf8UTdqH0 QDvnMhLhkJOV66KRcJ5U+aq8vDgVsTw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-4DTeeM-2PU2WpFpu9IYBjA-1; Fri, 21 Oct 2022 01:49:02 -0400 X-MC-Unique: 4DTeeM-2PU2WpFpu9IYBjA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 689EF1C09B80; Fri, 21 Oct 2022 05:49:01 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 100741121315; Fri, 21 Oct 2022 05:48:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id ACD4321E6686; Fri, 21 Oct 2022 07:48:55 +0200 (CEST) From: Markus Armbruster To: Laurent Vivier Cc: qemu-devel@nongnu.org, Paul Durrant , Thomas Huth , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , "Dr. David Alan Gilbert" , Greg Kurz , Stefano Stabellini , David Gibson , Eric Blake , xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Stefan Weil , Paolo Bonzini , Jason Wang , Samuel Thibault , Anthony Perard Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state References: <20221020162558.123284-1-lvivier@redhat.com> <20221020162558.123284-18-lvivier@redhat.com> Date: Fri, 21 Oct 2022 07:48:55 +0200 In-Reply-To: <20221020162558.123284-18-lvivier@redhat.com> (Laurent Vivier's message of "Thu, 20 Oct 2022 18:25:58 +0200") Message-ID: <87pmel4th4.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Laurent Vivier writes: > The netdev reports NETDEV_STREAM_CONNECTED event when the backend > is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected. Use cases? Could similar event signalling be useful for other kinds of netdev backends? > The NETDEV_STREAM_CONNECTED event includes the URI of the destination > address. No more. Easy fix: scratch "the URI of". > Signed-off-by: Laurent Vivier > Acked-by: Michael S. Tsirkin > --- > net/stream.c | 9 +++++++-- > qapi/net.json | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 56 insertions(+), 2 deletions(-) > > diff --git a/net/stream.c b/net/stream.c > index 95d6b910407d..cac01d4d792a 100644 > --- a/net/stream.c > +++ b/net/stream.c > @@ -38,6 +38,7 @@ > #include "io/channel.h" > #include "io/channel-socket.h" > #include "io/net-listener.h" > +#include "qapi/qapi-events-net.h" > > typedef struct NetStreamState { > NetClientState nc; > @@ -168,6 +169,8 @@ static gboolean net_stream_send(QIOChannel *ioc, > s->nc.link_down = true; > qemu_set_info_str(&s->nc, ""); > > + qapi_event_send_netdev_stream_disconnected(s->nc.name); > + > return G_SOURCE_REMOVE; > } > buf = buf1; > @@ -244,8 +247,8 @@ static void net_stream_listen(QIONetListener *listener, > uri = socket_uri(addr); > qemu_set_info_str(&s->nc, uri); > g_free(uri); > + qapi_event_send_netdev_stream_connected(s->nc.name, addr); > qapi_free_SocketAddress(addr); > - Don't add this blank line in PATCH 15, please. > } > > static void net_stream_server_listening(QIOTask *task, gpointer opaque) > @@ -327,7 +330,6 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque) > goto error; > } > g_assert(ret == 0); > - qapi_free_SocketAddress(addr); > > net_socket_rs_init(&s->rs, net_stream_rs_finalize, false); > > @@ -338,6 +340,9 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque) > s, NULL); > s->nc.link_down = false; > > + qapi_event_send_netdev_stream_connected(s->nc.name, addr); > + qapi_free_SocketAddress(addr); > + > return; > error: > object_unref(OBJECT(s->ioc)); Could put the qapi_free_SocketAddress() in its final place in PATCH 15 already to reduce churn. Up to you. > diff --git a/qapi/net.json b/qapi/net.json > index 39388b1b6c41..c37b24717382 100644 > --- a/qapi/net.json > +++ b/qapi/net.json > @@ -895,3 +895,52 @@ > ## > { 'event': 'FAILOVER_NEGOTIATED', > 'data': {'device-id': 'str'} } > + > +## > +# @NETDEV_STREAM_CONNECTED: > +# > +# Emitted when the netdev stream backend is connected > +# > +# @netdev-id: QEMU netdev id that is connected > +# @addr: The destination address > +# > +# Since: 7.2 > +# > +# Example: > +# > +# <- { "event": "NETDEV_STREAM_CONNECTED", > +# "data": { "netdev-id": "netdev0", > +# "addr": { "port": "47666", "ipv6": true, > +# "host": "::1", "type": "inet" } }, > +# "timestamp": { "seconds": 1666269863, "microseconds": 311222 } } > +# > +# or > +# > +# <- { "event": "NETDEV_STREAM_CONNECTED", > +# "data": { "netdev-id": "netdev0", > +# "addr": { "path": "/tmp/qemu0", "type": "unix" } }, > +# "timestamp": { "seconds": 1666269706, "microseconds": 413651 } } > +# > +## > +{ 'event': 'NETDEV_STREAM_CONNECTED', > + 'data': { 'netdev-id': 'str', > + 'addr': 'SocketAddress' } } > + > +## > +# @NETDEV_STREAM_DISCONNECTED: > +# > +# Emitted when the netdev stream backend is disconnected > +# > +# @netdev-id: QEMU netdev id that is disconnected > +# > +# Since: 7.2 > +# > +# Example: > +# > +# <- { 'event': 'NETDEV_STREAM_DISCONNECTED', > +# 'data': {'netdev-id': 'netdev0'}, > +# 'timestamp': {'seconds': 1663330937, 'microseconds': 526695} } > +# > +## > +{ 'event': 'NETDEV_STREAM_DISCONNECTED', > + 'data': { 'netdev-id': 'str' } } Schema looks good to me.