From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9578C433EF for ; Thu, 31 Mar 2022 13:27:15 +0000 (UTC) Received: from localhost ([::1]:42832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZupW-0000gn-Ed for qemu-devel@archiver.kernel.org; Thu, 31 Mar 2022 09:27:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZuoQ-0008Ae-Pd; Thu, 31 Mar 2022 09:26:06 -0400 Received: from mail05.asahi-net.or.jp ([202.224.55.45]:33331) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZuoO-0008N0-61; Thu, 31 Mar 2022 09:26:05 -0400 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail05.asahi-net.or.jp (Postfix) with ESMTPA id 73380205B7; Thu, 31 Mar 2022 22:25:56 +0900 (JST) Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id C96C31C01ED; Thu, 31 Mar 2022 22:25:55 +0900 (JST) Date: Thu, 31 Mar 2022 22:25:54 +0900 Message-ID: <87pmm2mexp.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Thomas Huth Subject: Re: [PATCH] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT double definition In-Reply-To: <20220330134302.979686-1-thuth@redhat.com> References: <20220330134302.979686-1-thuth@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=202.224.55.45; envelope-from=ysato@users.sourceforge.jp; helo=mail05.asahi-net.or.jp X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL=1.31, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Magnus Damm , qemu-devel@nongnu.org, Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 30 Mar 2022 22:43:02 +0900, Thomas Huth wrote: > > Seen while compiling on Alpine: > > In file included from ../linux-user/strace.c:17: > In file included from ../linux-user/qemu.h:11: > In file included from ../linux-user/syscall_defs.h:1247: > ../linux-user/sh4/termbits.h:276:10: warning: 'TIOCSER_TEMT' macro redefined > [-Wmacro-redefined] > # define TIOCSER_TEMT 0x01 /* Transmitter physically empty */ > ^ > /usr/include/sys/ioctl.h:50:9: note: previous definition is here > #define TIOCSER_TEMT 1 > ^ > 1 warning generated. > > Add the TARGET_ prefix here, too, like we do it on the other architectures. > > Signed-off-by: Thomas Huth > --- > linux-user/sh4/termbits.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/sh4/termbits.h b/linux-user/sh4/termbits.h > index f91b5c51cf..eeabd2d7a9 100644 > --- a/linux-user/sh4/termbits.h > +++ b/linux-user/sh4/termbits.h > @@ -273,7 +273,7 @@ ebugging only */ > #define TARGET_TIOCSERGETLSR TARGET_IOR('T', 89, unsigned int) /* 0x5459 */ /* Get line sta > tus register */ > /* ioctl (fd, TIOCSERGETLSR, &result) where result may be as below */ > -# define TIOCSER_TEMT 0x01 /* Transmitter physically empty */ > +# define TARGET_TIOCSER_TEMT 0x01 /* Transmitter physically empty */ > #define TARGET_TIOCSERGETMULTI TARGET_IOR('T', 90, int) /* 0x545A > */ /* Get multiport config */ > #define TARGET_TIOCSERSETMULTI TARGET_IOW('T', 91, int) /* 0x545B > -- > 2.27.0 > Reviewed-by: Yoshinori Sato -- Yosinori Sato