From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F6FCC433EF for ; Mon, 14 Feb 2022 14:20:54 +0000 (UTC) Received: from localhost ([::1]:36146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJcDl-0002y2-Jy for qemu-devel@archiver.kernel.org; Mon, 14 Feb 2022 09:20:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJbIR-0002FK-Vn; Mon, 14 Feb 2022 08:21:40 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:14750 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJbIQ-0003hn-1x; Mon, 14 Feb 2022 08:21:39 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21EC2Nov022971; Mon, 14 Feb 2022 13:21:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=cNuY+lH0s5P9gB037vN4OCYaXUgJqC40S8xjSj5jJlI=; b=HM8laUJLFp3fyZKla8pP6FH3hfiN3CbmIYArKgf3f4uFr+cS56N9PYe30a1EPRcqZp5o x5BpJqKwIfkswpVJ7fDHJgmqFx+jf2MqbJXclaZv6yl6WyDmAgwBk5Sg5lp/zU6YEJ21 NPs3ex5rM1IOs3UqkEoks95hgggrW02R2HCmbR/yg2+9/emTBEBYHq68HBfjg+iQz6hl /I1Jzjz+eed3HZjX0zDU/qKyv2ChOLKUY0kgRY24Plb1SS5w/o/nReB+FGAwU9cET1LO OSf0etDXC5Trhc1HL5Y6oLGD+xLQ/2S2VwbcZAMh4TiQGcj5FJsR0OwJZfDwZ4XEKfUN GA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3e6ycqsfcf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Feb 2022 13:21:36 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 21EAwMZZ022276; Mon, 14 Feb 2022 13:21:36 GMT Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0b-001b2d01.pphosted.com with ESMTP id 3e6ycqsfc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Feb 2022 13:21:36 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 21EDDkFZ020543; Mon, 14 Feb 2022 13:21:35 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma05wdc.us.ibm.com with ESMTP id 3e64h9qny8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Feb 2022 13:21:35 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 21EDLYec14156270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Feb 2022 13:21:34 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0ABB2AE06B; Mon, 14 Feb 2022 13:21:34 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8D30AE062; Mon, 14 Feb 2022 13:21:32 +0000 (GMT) Received: from localhost (unknown [9.211.47.159]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS; Mon, 14 Feb 2022 13:21:32 +0000 (GMT) From: Fabiano Rosas To: Nicholas Piggin , qemu-ppc@nongnu.org Subject: Re: [PATCH] target/ppc: raise HV interrupts for partition table entry problems In-Reply-To: <20220214123101.1546351-1-npiggin@gmail.com> References: <20220214123101.1546351-1-npiggin@gmail.com> Date: Mon, 14 Feb 2022 10:21:29 -0300 Message-ID: <87pmnplh2e.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: TukYA4sNPg65owFDpfodbhQb2Q3giTj8 X-Proofpoint-GUID: GZ9-9lyHdXFlXUHothJGlzSMFFq4sGJW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-14_05,2022-02-14_03,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202140076 Received-SPF: pass client-ip=148.163.158.5; envelope-from=farosas@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Nicholas Piggin Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Nicholas Piggin writes: > Invalid or missing partition table entry exceptions should cause HV > interrupts. HDSISR is set to bad MMU config, which is consistent with > the ISA and experimentally matches what POWER9 generates. > > Signed-off-by: Nicholas Piggin Reviewed-by: Fabiano Rosas > --- > target/ppc/mmu-radix64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c > index 040c055bff..54fb3ce98d 100644 > --- a/target/ppc/mmu-radix64.c > +++ b/target/ppc/mmu-radix64.c > @@ -560,13 +560,13 @@ static bool ppc_radix64_xlate_impl(PowerPCCPU *cpu, vaddr eaddr, > } else { > if (!ppc64_v3_get_pate(cpu, lpid, &pate)) { > if (guest_visible) { > - ppc_radix64_raise_si(cpu, access_type, eaddr, DSISR_NOPTE); > + ppc_radix64_raise_hsi(cpu, access_type, eaddr, eaddr, DSISR_R_BADCONFIG); > } > return false; > } > if (!validate_pate(cpu, lpid, &pate)) { > if (guest_visible) { > - ppc_radix64_raise_si(cpu, access_type, eaddr, DSISR_R_BADCONFIG); > + ppc_radix64_raise_hsi(cpu, access_type, eaddr, eaddr, DSISR_R_BADCONFIG); > } > return false; > }