From: "Keith Packard" via <qemu-devel@nongnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-arm <qemu-arm@nongnu.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"open list:RISC-V" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories
Date: Tue, 27 Oct 2020 14:56:01 -0700 [thread overview]
Message-ID: <87pn53e3ke.fsf@keithp.com> (raw)
In-Reply-To: <CAFEAcA-0_WLMP1Y1sgcu7Ng+0w8Ovt9DVWzYU8ZA_FA2+bwcUw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
Peter Maydell <peter.maydell@linaro.org> writes:
>> +specific_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
>
> I think this adds this file to the compilation for all TCG targets;
> you only want it for targets which have Arm-semihosting-ABI compatible
> semihosting. (Various other targets either don't have semihosting
> or have their own ABI.)
Right. These should have been target-specific source sets so that the
file was only added to those targets:
arm_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
riscv_ss.add(files('common-semi.c'))
This appears to work in my testing (building arm, risc-v and x86_64
configs).
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-10-27 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 21:28 [PATCH 0/4] riscv: Add semihosting support [v10] Keith Packard via
2020-10-26 21:28 ` [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories Keith Packard via
2020-10-27 20:32 ` Alistair Francis
2020-10-27 21:20 ` Peter Maydell
2020-10-27 21:56 ` Keith Packard via [this message]
2020-10-27 23:38 ` Peter Maydell
2020-10-28 1:33 ` Keith Packard via
[not found] ` <87lffqmwi6.fsf@linaro.org>
2020-10-28 15:37 ` Keith Packard via
2020-10-28 19:14 ` Keith Packard via
2020-10-26 21:28 ` [PATCH 2/4] semihosting: Change common-semi API to be architecture-independent Keith Packard via
2020-10-26 21:28 ` [PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState * Keith Packard via
2020-10-26 21:28 ` [PATCH 4/4] riscv: Add semihosting support [v10] Keith Packard via
2020-10-26 21:42 ` [PATCH 0/4] " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn53e3ke.fsf@keithp.com \
--to=qemu-devel@nongnu.org \
--cc=Alistair.Francis@wdc.com \
--cc=alex.bennee@linaro.org \
--cc=kbastian@mail.uni-paderborn.de \
--cc=keithp@keithp.com \
--cc=laurent@vivier.eu \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).