From: "Alex Bennée" <alex.bennee@linaro.org>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Emilio G . Cota" <cota@braap.org>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/6] Enable plugin support on msys2/mingw
Date: Tue, 06 Oct 2020 12:35:19 +0100 [thread overview]
Message-ID: <87pn5v1tag.fsf@linaro.org> (raw)
In-Reply-To: <20201001163429.1348-1-luoyonggang@gmail.com>
Yonggang Luo <luoyonggang@gmail.com> writes:
> V2-V3
> Split following patches out
>
> V1-V2
> 1. Fixes review comments
> 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0
> 3. Revise the loader to support for version 0 and 1
> 4. By export function qemu_plugin_initialize in plugin, and call it in loader=
> , so
> we have no need call it in every plugin. And also provide a standard implem=
> entation,
> anyway, use can also override it.
>
> Add this feature on msys2/mingw by using glib provided cross-platform dlsym f=
> unctional.
I've grabbed the first two fixes into plugins/next for now. Aside from
fixing the review comments I'd like to have an indication that the
proposed change to the API linking doesn't adversely affect the
performance of the plugins.
It might be worth enabling a --enable-plugins build for mingw gitlab as Cirrus
seems a bit broken at the moment.
Thanks,
--
Alex Bennée
next prev parent reply other threads:[~2020-10-06 11:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 16:34 [PATCH v3 0/6] Enable plugin support on msys2/mingw Yonggang Luo
2020-10-01 16:34 ` [PATCH v3 1/6] plugins: Fixes a issue when dlsym failed, the handle not closed Yonggang Luo
2020-10-05 9:59 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 2/6] plugin: Fixes compiling errors on msys2/mingw Yonggang Luo
2020-10-05 10:00 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 3/6] cirrus: Enable plugin in cirrus for windows Yonggang Luo
2020-10-05 10:17 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 4/6] plugin: define QEMU_PLUGIN_API_IMPLEMENTATION first Yonggang Luo
2020-10-05 10:44 ` Alex Bennée
2020-10-05 15:58 ` 罗勇刚(Yonggang Luo)
2020-10-01 16:34 ` [PATCH v3 5/6] plugin: getting qemu_plugin_get_hwaddr only expose one function prototype Yonggang Luo
2020-10-05 10:48 ` Alex Bennée
2020-10-05 15:34 ` 罗勇刚(Yonggang Luo)
2020-10-05 15:46 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 6/6] plugin: Getting qemu-plugin works under win32 Yonggang Luo
2020-10-06 11:29 ` Alex Bennée
2020-10-06 12:08 ` 罗勇刚(Yonggang Luo)
2020-10-06 11:35 ` Alex Bennée [this message]
2021-01-27 3:52 ` [PATCH v3 0/6] Enable plugin support on msys2/mingw 罗勇刚(Yonggang Luo)
2021-02-10 15:10 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn5v1tag.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).