From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps
Date: Mon, 06 Apr 2020 10:09:19 +0100 [thread overview]
Message-ID: <87pnclaslc.fsf@linaro.org> (raw)
In-Reply-To: <830061f9-91cd-145c-4388-f2bfe9a3d7a6@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 4/3/20 12:11 PM, Alex Bennée wrote:
>> + e->is_read = fields[1][0] == 'r' ? true : false;
>> + e->is_write = fields[1][1] == 'w' ? true : false;
>> + e->is_exec = fields[1][2] == 'x' ? true : false;
>> + e->is_priv = fields[1][3] == 'p' ? true : false;
>
> Drop the redundant ? true : false. That is of course the result of the boolean
> operation.
doh! Fortunately the compiler was smart enough to see through my idiocy...
>
>> + errors += qemu_strtoi(fields[4], NULL, 10, &e->inode);
>
> The root of the typedef chain for ino_t is
>
> /usr/include/asm-generic/posix_types.h:typedef __kernel_ulong_t __kernel_ino_t;
>
> so I think you should just go ahead and use unsigned long here too. Or maybe
> even uint64_t, because 32-bit has ino64_t, and could in fact have a Large
> Number here.
Will fix.
>
>
> r~
--
Alex Bennée
next prev parent reply other threads:[~2020-04-06 9:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 19:11 [PATCH v3 for 5.0-rc2 00/12] a selection of random fixes Alex Bennée
2020-04-03 19:11 ` [PATCH v3 01/12] elf-ops: bail out if we have no function symbols Alex Bennée
2020-04-03 19:11 ` [PATCH v3 02/12] linux-user: protect fcntl64 with an #ifdef Alex Bennée
2020-04-03 19:11 ` [PATCH v3 03/12] tests/tcg: remove extraneous pasting macros Alex Bennée
2020-04-03 19:11 ` [PATCH v3 04/12] linux-user: more debug for init_guest_space Alex Bennée
2020-04-03 20:39 ` Philippe Mathieu-Daudé
2020-04-03 19:11 ` [PATCH v3 05/12] target/xtensa: add FIXME for translation memory leak Alex Bennée
2020-04-03 19:11 ` [PATCH v3 06/12] gdbstub: fix compiler complaining Alex Bennée
2020-04-06 10:21 ` Chenqun (kuhn)
2020-04-03 19:11 ` [PATCH v3 07/12] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal Alex Bennée
2020-04-03 19:11 ` [PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps Alex Bennée
2020-04-04 0:33 ` Richard Henderson
2020-04-06 9:09 ` Alex Bennée [this message]
2020-04-03 19:11 ` [PATCH v3 09/12] linux-user: clean-up padding on /proc/self/maps Alex Bennée
2020-04-03 19:11 ` [PATCH v3 10/12] target/arm: don't expose "ieee_half" via gdbstub Alex Bennée
2020-04-03 19:11 ` [PATCH v3 11/12] hw/core: properly terminate loading .hex on EOF record Alex Bennée
2020-04-03 19:11 ` [PATCH v3 12/12] configure: Add -Werror to PIE probe Alex Bennée
2020-04-06 21:32 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnclaslc.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).