From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v31 23/23] fix warning.
Date: Tue, 25 Feb 2020 00:02:36 +0900 [thread overview]
Message-ID: <87pne49gfn.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <CAFEAcA-1Uu2EAHt7d7bhRQC5o9wqmX_DNg6B6S5wsqSA9joTVQ@mail.gmail.com>
On Mon, 24 Feb 2020 23:28:24 +0900,
Peter Maydell wrote:
>
> On Sun, 23 Feb 2020 at 13:33, Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > hw/rx/rx-virt.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c
> > index 6cf7936201..4ee6647728 100644
> > --- a/hw/rx/rx-virt.c
> > +++ b/hw/rx/rx-virt.c
> > @@ -90,8 +90,10 @@ static void rxvirt_init(MachineState *machine)
> >
> > /* Load kernel and dtb */
> > if (kernel_filename) {
> > - /* The kernel image is loaded into
> > - the latter half of the SDRAM space. */
> > + /*
> > + The kernel image is loaded into
> > + the latter half of the SDRAM space.
> > + */
>
> The comment format we prefer is described in CODING_STYLE.rst;
> for block comments, and it looks like this:
> /*
> * Leading and closing slash-star and star-slash
> * on their own line; each other line has a star
> * in the left column.
> */
>
> thanks
> -- PMM
My local file using your suggested style.
91 /* Load kernel and dtb */
92 if (kernel_filename) {
93 /*
94 * The kernel image is loaded into
95 * the latter half of the SDRAM space.
96 */
97 kernel_offset = machine->ram_size / 2;
98 rx_load_image(RXCPU(first_cpu), kernel_filename,
99 SDRAM_BASE + kernel_offset, kernel_offset);
Check that I may make a mistake in the file.
--
Yosinori Sato
prev parent reply other threads:[~2020-02-24 15:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 13:27 [PATCH RESEND v31 00/22] Add RX archtecture support Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 01/22] MAINTAINERS: Add RX Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 02/22] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 03/22] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 04/22] target/rx: TCG translation Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 05/22] target/rx: TCG helper Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 06/22] target/rx: CPU definition Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 07/22] target/rx: RX disassembler Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 08/22] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 09/22] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 10/22] target/rx: Use prt_ldmi for XCHG_mr disassembly Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 11/22] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 12/22] target/rx: Collect all bytes during disassembly Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 13/22] target/rx: Dump bytes for each insn " Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 14/22] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 15/22] hw/timer: RX62N internal timer modules Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 16/22] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 17/22] hw/rx: RX Target hardware definition Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 18/22] hw/rx: Honor -accel qtest Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 19/22] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 20/22] Add rx-softmmu Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 21/22] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 22/22] qemu-doc.texi: Add RX section Yoshinori Sato
2020-02-23 13:27 ` [PATCH v31 23/23] fix warning Yoshinori Sato
2020-02-24 8:51 ` Philippe Mathieu-Daudé
2020-02-24 13:56 ` Yoshinori Sato
2020-02-24 14:00 ` Philippe Mathieu-Daudé
2020-02-24 14:28 ` Peter Maydell
2020-02-24 15:02 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pne49gfn.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).