From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A991C11D2F for ; Mon, 24 Feb 2020 15:03:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F0F52072D for ; Mon, 24 Feb 2020 15:03:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F0F52072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6FGd-0002nl-Gs for qemu-devel@archiver.kernel.org; Mon, 24 Feb 2020 10:03:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55460) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6FFr-0001vq-PI for qemu-devel@nongnu.org; Mon, 24 Feb 2020 10:02:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6FFo-0002f3-QV for qemu-devel@nongnu.org; Mon, 24 Feb 2020 10:02:43 -0500 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:34188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j6FFo-0002cj-IP for qemu-devel@nongnu.org; Mon, 24 Feb 2020 10:02:40 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 9701BE2A26; Tue, 25 Feb 2020 00:02:37 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 06C6A24008E; Tue, 25 Feb 2020 00:02:37 +0900 (JST) Date: Tue, 25 Feb 2020 00:02:36 +0900 Message-ID: <87pne49gfn.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Peter Maydell Subject: Re: [PATCH v31 23/23] fix warning. In-Reply-To: References: <20200223132750.69480-1-ysato@users.sourceforge.jp> <20200223132750.69480-24-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.15 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 24 Feb 2020 23:28:24 +0900, Peter Maydell wrote: > > On Sun, 23 Feb 2020 at 13:33, Yoshinori Sato wrote: > > > > Signed-off-by: Yoshinori Sato > > --- > > hw/rx/rx-virt.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c > > index 6cf7936201..4ee6647728 100644 > > --- a/hw/rx/rx-virt.c > > +++ b/hw/rx/rx-virt.c > > @@ -90,8 +90,10 @@ static void rxvirt_init(MachineState *machine) > > > > /* Load kernel and dtb */ > > if (kernel_filename) { > > - /* The kernel image is loaded into > > - the latter half of the SDRAM space. */ > > + /* > > + The kernel image is loaded into > > + the latter half of the SDRAM space. > > + */ > > The comment format we prefer is described in CODING_STYLE.rst; > for block comments, and it looks like this: > /* > * Leading and closing slash-star and star-slash > * on their own line; each other line has a star > * in the left column. > */ > > thanks > -- PMM My local file using your suggested style. 91 /* Load kernel and dtb */ 92 if (kernel_filename) { 93 /* 94 * The kernel image is loaded into 95 * the latter half of the SDRAM space. 96 */ 97 kernel_offset = machine->ram_size / 2; 98 rx_load_image(RXCPU(first_cpu), kernel_filename, 99 SDRAM_BASE + kernel_offset, kernel_offset); Check that I may make a mistake in the file. -- Yosinori Sato