* [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME
@ 2018-07-10 9:44 Peter Xu
2018-07-10 9:57 ` Dr. David Alan Gilbert
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Xu @ 2018-07-10 9:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Juan Quintela, Dr . David Alan Gilbert, peterx
It was accidently added before MIG_CMD_PACKAGED so it might break
command compatibility when we run postcopy migration between old/new
QEMUs. Fix that up quickly before the QEMU 3.0 release.
Reported-by: Lukáš Doktor <ldoktor@redhat.com>
Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index c2f34ffc7c..0d2c4a0739 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -81,8 +81,8 @@ enum qemu_vm_cmd {
MIG_CMD_POSTCOPY_RAM_DISCARD, /* A list of pages to discard that
were previously sent during
precopy but are dirty. */
- MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
MIG_CMD_PACKAGED, /* Send a wrapped stream within this stream */
+ MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
MIG_CMD_RECV_BITMAP, /* Request for recved bitmap on dst */
MIG_CMD_MAX
};
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME
2018-07-10 9:44 [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME Peter Xu
@ 2018-07-10 9:57 ` Dr. David Alan Gilbert
2018-07-10 12:19 ` Dr. David Alan Gilbert
2018-07-10 12:22 ` Juan Quintela
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2018-07-10 9:57 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel, Juan Quintela, ldoktor
* Peter Xu (peterx@redhat.com) wrote:
> It was accidently added before MIG_CMD_PACKAGED so it might break
> command compatibility when we run postcopy migration between old/new
> QEMUs. Fix that up quickly before the QEMU 3.0 release.
>
> Reported-by: Lukáš Doktor <ldoktor@redhat.com>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index c2f34ffc7c..0d2c4a0739 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -81,8 +81,8 @@ enum qemu_vm_cmd {
> MIG_CMD_POSTCOPY_RAM_DISCARD, /* A list of pages to discard that
> were previously sent during
> precopy but are dirty. */
> - MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_PACKAGED, /* Send a wrapped stream within this stream */
> + MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_RECV_BITMAP, /* Request for recved bitmap on dst */
> MIG_CMD_MAX
> };
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME
2018-07-10 9:44 [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME Peter Xu
2018-07-10 9:57 ` Dr. David Alan Gilbert
@ 2018-07-10 12:19 ` Dr. David Alan Gilbert
2018-07-10 12:22 ` Juan Quintela
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2018-07-10 12:19 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel, Juan Quintela
* Peter Xu (peterx@redhat.com) wrote:
> It was accidently added before MIG_CMD_PACKAGED so it might break
> command compatibility when we run postcopy migration between old/new
> QEMUs. Fix that up quickly before the QEMU 3.0 release.
>
> Reported-by: Lukáš Doktor <ldoktor@redhat.com>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Queued
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index c2f34ffc7c..0d2c4a0739 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -81,8 +81,8 @@ enum qemu_vm_cmd {
> MIG_CMD_POSTCOPY_RAM_DISCARD, /* A list of pages to discard that
> were previously sent during
> precopy but are dirty. */
> - MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_PACKAGED, /* Send a wrapped stream within this stream */
> + MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_RECV_BITMAP, /* Request for recved bitmap on dst */
> MIG_CMD_MAX
> };
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME
2018-07-10 9:44 [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME Peter Xu
2018-07-10 9:57 ` Dr. David Alan Gilbert
2018-07-10 12:19 ` Dr. David Alan Gilbert
@ 2018-07-10 12:22 ` Juan Quintela
2 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2018-07-10 12:22 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel, Dr . David Alan Gilbert
Peter Xu <peterx@redhat.com> wrote:
> It was accidently added before MIG_CMD_PACKAGED so it might break
> command compatibility when we run postcopy migration between old/new
> QEMUs. Fix that up quickly before the QEMU 3.0 release.
>
> Reported-by: Lukáš Doktor <ldoktor@redhat.com>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index c2f34ffc7c..0d2c4a0739 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -81,8 +81,8 @@ enum qemu_vm_cmd {
> MIG_CMD_POSTCOPY_RAM_DISCARD, /* A list of pages to discard that
> were previously sent during
> precopy but are dirty. */
> - MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_PACKAGED, /* Send a wrapped stream within this stream */
> + MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_RECV_BITMAP, /* Request for recved bitmap on dst */
> MIG_CMD_MAX
> };
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-10 12:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-10 9:44 [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME Peter Xu
2018-07-10 9:57 ` Dr. David Alan Gilbert
2018-07-10 12:19 ` Dr. David Alan Gilbert
2018-07-10 12:22 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).