From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX8ht-000880-LX for qemu-devel@nongnu.org; Mon, 17 Jul 2017 12:17:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX8ho-0002Aq-UD for qemu-devel@nongnu.org; Mon, 17 Jul 2017 12:17:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44212) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX8ho-0002AV-Ox for qemu-devel@nongnu.org; Mon, 17 Jul 2017 12:17:08 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 72B03D0A8B for ; Mon, 17 Jul 2017 16:17:07 +0000 (UTC) From: Juan Quintela In-Reply-To: <20170714115736.13693-3-dgilbert@redhat.com> (David Alan Gilbert's message of "Fri, 14 Jul 2017 12:57:33 +0100") References: <20170714115736.13693-1-dgilbert@redhat.com> <20170714115736.13693-3-dgilbert@redhat.com> Reply-To: quintela@redhat.com Date: Mon, 17 Jul 2017 18:16:58 +0200 Message-ID: <87pocz11j9.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 2/5] migration: Close file on failed migration load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Closing the file before exit on a failure allows > the source to cleanup better, especially with RDMA. > > Partial fix for https://bugs.launchpad.net/qemu/+bug/1545052 > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Peter Xu Reviewed-by: Juan Quintela