From: Vincent Bernat <Vincent.Bernat@exoscale.ch>
To: qemu-devel@nongnu.org, famz@redhat.com,
samuel.thibault@ens-lyon.org, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol
Date: Thu, 17 Nov 2016 16:58:31 +0100 [thread overview]
Message-ID: <87poluw120.fsf@luffy.cx> (raw)
In-Reply-To: <147939644067.238.10993052538213615164@9040ca97f87d> (no-reply@patchew.org's message of "Thu, 17 Nov 2016 07:27:23 -0800 (PST)")
❦ 17 novembre 2016 07:27 -0800, no-reply@patchew.org :
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: tftp: fake support for netascii protocol...
> ERROR: suspect code indent for conditional statements (2, 6)
> #24: FILE: slirp/tftp.c:329:
> + if (strcasecmp(&tp->x.tp_buf[k], "octet") == 0) {
> + k += 6;
>
> ERROR: suspect code indent for conditional statements (2, 6)
> #26: FILE: slirp/tftp.c:331:
> + } else if (strcasecmp(&tp->x.tp_buf[k], "netascii") == 0) {
> + k += 9;
Indentation is consistent with what the remaining of the file.
> ERROR: Missing Signed-off-by: line(s)
Should I resend the patch for that or the amendment I sent in another
mail is sufficient?
--
Vincent Bernat — Vincent.Bernat@exoscale.ch
❬❱ https://www.exoscale.ch
prev parent reply other threads:[~2016-11-17 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 12:20 [Qemu-devel] [PATCH] tftp: fake support for netascii protocol Vincent Bernat
2016-11-17 12:22 ` Vincent Bernat
2016-11-18 17:52 ` Samuel Thibault
2016-11-17 15:27 ` no-reply
2016-11-17 15:58 ` Vincent Bernat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poluw120.fsf@luffy.cx \
--to=vincent.bernat@exoscale.ch \
--cc=famz@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).