From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57764)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Vincent.Bernat@exoscale.ch>) id 1c7P5C-0005HA-F2
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 10:58:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Vincent.Bernat@exoscale.ch>) id 1c7P58-0006Dz-M6
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 10:58:38 -0500
Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:36233)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Vincent.Bernat@exoscale.ch>)
	id 1c7P58-0006DG-E4
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 10:58:34 -0500
Received: by mail-wm0-x233.google.com with SMTP id g23so319589975wme.1
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2016 07:58:34 -0800 (PST)
From: Vincent Bernat <Vincent.Bernat@exoscale.ch>
References: <147939644067.238.10993052538213615164@9040ca97f87d>
Date: Thu, 17 Nov 2016 16:58:31 +0100
In-Reply-To: <147939644067.238.10993052538213615164@9040ca97f87d>
	(no-reply@patchew.org's message of "Thu, 17 Nov 2016 07:27:23 -0800
	(PST)")
Message-ID: <87poluw120.fsf@luffy.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, famz@redhat.com, samuel.thibault@ens-lyon.org, jan.kiszka@siemens.com

 =E2=9D=A6 17 novembre 2016 07:27 -0800, no-reply@patchew.org=C2=A0:

> =3D=3D=3D OUTPUT BEGIN =3D=3D=3D
> Checking PATCH 1/1: tftp: fake support for netascii protocol...
> ERROR: suspect code indent for conditional statements (2, 6)
> #24: FILE: slirp/tftp.c:329:
> +  if (strcasecmp(&tp->x.tp_buf[k], "octet") =3D=3D 0) {
> +      k +=3D 6;
>
> ERROR: suspect code indent for conditional statements (2, 6)
> #26: FILE: slirp/tftp.c:331:
> +  } else if (strcasecmp(&tp->x.tp_buf[k], "netascii") =3D=3D 0) {
> +      k +=3D 9;

Indentation is consistent with what the remaining of the file.

> ERROR: Missing Signed-off-by: line(s)

Should I resend the patch for that or the amendment I sent in another
mail is sufficient?
--=20
Vincent Bernat =E2=80=94 Vincent.Bernat@exoscale.ch
=E2=9D=AC=E2=9D=B1 https://www.exoscale.ch