From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2dtg-0007fn-71 for qemu-devel@nongnu.org; Fri, 04 Nov 2016 08:47:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2dtf-0007vx-Df for qemu-devel@nongnu.org; Fri, 04 Nov 2016 08:47:04 -0400 From: Juan Quintela In-Reply-To: <1471343175-14945-5-git-send-email-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Tue, 16 Aug 2016 13:26:01 +0300") References: <1471343175-14945-1-git-send-email-vsementsov@virtuozzo.com> <1471343175-14945-5-git-send-email-vsementsov@virtuozzo.com> Reply-To: quintela@redhat.com Date: Fri, 04 Nov 2016 13:46:51 +0100 Message-ID: <87pombo1j8.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 04/18] migration: introduce postcopy-only pending List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, famz@redhat.com, stefanha@redhat.com, amit.shah@redhat.com, mreitz@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org, dgilbert@redhat.com, den@openvz.org, jsnow@redhat.com, lirans@il.ibm.com Vladimir Sementsov-Ogievskiy wrote: > There would be savevm states (dirty-bitmap) which can migrate only in > postcopy stage. The corresponding pending is introduced here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/migration/vmstate.h | 5 +++-- > include/sysemu/sysemu.h | 5 +++-- > migration/block.c | 7 ++++--- > migration/migration.c | 15 ++++++++------- > migration/ram.c | 9 +++++---- > migration/savevm.c | 12 +++++++----- > migration/trace-events | 2 +- > 7 files changed, 31 insertions(+), 24 deletions(-) > > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > index 5c30ef7..dc656be 100644 > --- a/include/migration/vmstate.h > +++ b/include/migration/vmstate.h > @@ -58,8 +58,9 @@ typedef struct SaveVMHandlers { > /* This runs outside the iothread lock! */ > int (*save_live_setup)(QEMUFile *f, void *opaque); > void (*save_live_pending)(QEMUFile *f, void *opaque, uint64_t max_size, > - uint64_t *non_postcopiable_pending, > - uint64_t *postcopiable_pending); > + uint64_t *res_precopy_only, > + uint64_t *res_compatible, > + uint64_t *res_postcopy_only); Ouch, we really need to move to use an struct here :p But ugliness was already here. BTW, with only this patch, it is not clear to me what res_compatible mean > @@ -1133,7 +1135,7 @@ void qemu_savevm_state_pending(QEMUFile *f, uint64_t max_size, > } > } > se->ops->save_live_pending(f, se->opaque, max_size, > - res_non_postcopiable, res_postcopiable); > + res_precopy_only, res_compatible, res_postcopy_only); Indentation is wrong.