From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aZJFN-00070y-Tg
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 09:19:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aZJFJ-0005c7-PT
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 09:19:57 -0500
Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:38024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aZJFJ-0005bl-IT
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 09:19:53 -0500
Received: by mail-wm0-x22a.google.com with SMTP id a4so71871144wme.1
	for <qemu-devel@nongnu.org>; Fri, 26 Feb 2016 06:19:53 -0800 (PST)
References: <1456492533-17171-1-git-send-email-alex.bennee@linaro.org>
	<1456492533-17171-8-git-send-email-alex.bennee@linaro.org>
	<20160226140215.4wpdvt3xgnh2s6s7@hawk.localdomain>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <20160226140215.4wpdvt3xgnh2s6s7@hawk.localdomain>
Date: Fri, 26 Feb 2016 14:19:51 +0000
Message-ID: <87povj7dvc.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC 07/11] arm/run: allow aarch64 to start arm
	binaries
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: mttcg@greensocs.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, will.deacon@arm.com, a.rigo@virtualopensystems.com, crosthwaitepeter@gmail.com, pbonzini@redhat.com, rth@twiddle.net, aurelien@aurel32.net, fred.konrad@greensocs.com


Andrew Jones <drjones@redhat.com> writes:

> On Fri, Feb 26, 2016 at 01:15:29PM +0000, Alex Bennée wrote:
>> AArch64 hosts can happily run AArch32 binaries. We just need to ensure
>> that we use "cpu host,aarch64=off" when specifying the CPU type.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  arm/run | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/arm/run b/arm/run
>> index 0eaf23a..f1a6b7d 100755
>> --- a/arm/run
>> +++ b/arm/run
>> @@ -38,7 +38,15 @@ if [ "$HOST" = "aarch64" ] && [ "$ACCEL" = "kvm" ]; then
>>  	fi
>>  fi
>>
>> -qemu="${QEMU:-qemu-system-$ARCH_NAME}"
>> +if [ "$ARCH" = "arm" ] && [ "$HOST" = "aarch64" ]; then
>> +    qemu="${QEMU:-qemu-system-$HOST}"
>> +    if [ "$ACCEL" = "kvm" ]; then
>> +	processor="host,aarch64=off"
>> +    fi
>> +else
>> +	qemu="${QEMU:-qemu-system-$ARCH_NAME}"
>> +fi
>
> We've got 3382e7795 "arm/run: allow tests to run in AArch32 mode"
> already, so I this patch should no longer be necessary.

Ahh good spot. I'll drop that.

Thanks.

>
> Thanks,
> drew
>
>
>> +
>>  qpath=$(which $qemu 2>/dev/null)
>>
>>  if [ -z "$qpath" ]; then
>> --
>> 2.7.1
>>


--
Alex Bennée