From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: amit.shah@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] Unneeded NULL check
Date: Wed, 18 Nov 2015 13:02:50 +0100 [thread overview]
Message-ID: <87poz7ldlh.fsf@emacs.mitica> (raw)
In-Reply-To: <1447847321-20132-4-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Wed, 18 Nov 2015 11:48:41 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The check is unneccesary, we read the value at the start of the
> thread, use it, and never change it. The value is checked to be
> non-NULL before thread creation.
>
> Spotted by coverity, CID 1339211
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2015-11-18 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 11:48 [Qemu-devel] [PATCH 0/3] [For 2.5] Migration fixes Dr. David Alan Gilbert (git)
2015-11-18 11:48 ` [Qemu-devel] [PATCH 1/3] Set last_sent_block Dr. David Alan Gilbert (git)
2015-11-18 12:02 ` Juan Quintela
2015-11-18 11:48 ` [Qemu-devel] [PATCH 2/3] migration: Dead assignment of current_time Dr. David Alan Gilbert (git)
2015-11-18 12:02 ` Juan Quintela
2015-11-18 11:48 ` [Qemu-devel] [PATCH 3/3] Unneeded NULL check Dr. David Alan Gilbert (git)
2015-11-18 12:02 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poz7ldlh.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).