From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz1SA-00022k-KC for qemu-devel@nongnu.org; Wed, 18 Nov 2015 07:03:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz1S5-0002AF-4h for qemu-devel@nongnu.org; Wed, 18 Nov 2015 07:03:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz1S5-0002AA-07 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 07:03:05 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9C64EC049D4F for ; Wed, 18 Nov 2015 12:03:04 +0000 (UTC) From: Juan Quintela In-Reply-To: <1447847321-20132-4-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Wed, 18 Nov 2015 11:48:41 +0000") References: <1447847321-20132-1-git-send-email-dgilbert@redhat.com> <1447847321-20132-4-git-send-email-dgilbert@redhat.com> Date: Wed, 18 Nov 2015 13:02:50 +0100 Message-ID: <87poz7ldlh.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 3/3] Unneeded NULL check Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: amit.shah@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The check is unneccesary, we read the value at the start of the > thread, use it, and never change it. The value is checked to be > non-NULL before thread creation. > > Spotted by coverity, CID 1339211 > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela