From: Juan Quintela <quintela@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Amit Shah <amit.shah@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue
Date: Thu, 12 Nov 2015 15:22:17 +0100 [thread overview]
Message-ID: <87pozfqova.fsf@emacs.mitica> (raw)
In-Reply-To: <CAFEAcA-7oAeT0sJn158PZsYQ7hxzum8C+YvDFPEkVqif_RgZkA@mail.gmail.com> (Peter Maydell's message of "Thu, 12 Nov 2015 13:53:35 +0000")
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 12 November 2015 at 13:18, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 12 November 2015 at 13:08, Dr. David Alan Gilbert
>> <dgilbert@redhat.com> wrote:
>>> OK, can you try a simple migration by hand outside of the test harness;
>>> just something simple like:
>>>
>>> ./bin/qemu-system-x86_64 -M pc -nographic
>>> (qemu) migrate "exec: cat > /dev/null"
>>>
>>> and the same with q35 ?
>>
>> (qemu) migrate "exec: cat > /dev/null"
>> migrate_get_current do init of current_migration 65307
>> unqueue_page 65307
>> 0 qemu-system-x86_64 0x00000001067c01c3 qemu_mutex_lock + 83
>
> This turns out to be because migrate_init() is corrupting the
> mutex memory when it does "memset(s, 0, sizeof(*s))". Presumably
> Linux's initialized-mutex is all-zeroes, but OSX's is not.
grrr, that is probably the case. Thanks for pinponting this.
>
> thanks
> -- PMM
next prev parent reply other threads:[~2015-11-12 14:22 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 14:24 [Qemu-devel] [PULL 00/57] Migration pull (take 2) Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 01/57] Add postcopy documentation Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 02/57] Provide runtime Target page information Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 03/57] Move configuration section writing Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 04/57] Move page_size_init earlier Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 05/57] qemu_ram_block_from_host Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 06/57] qemu_ram_block_by_name Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 07/57] Rename mis->file to from_src_file Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 08/57] Add qemu_get_buffer_in_place to avoid copies some of the time Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 09/57] Add wrapper for setting blocking status on a QEMUFile Juan Quintela
2015-11-10 14:24 ` [Qemu-devel] [PULL 10/57] Add QEMU_MADV_NOHUGEPAGE Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 11/57] ram_debug_dump_bitmap: Dump a migration bitmap as text Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 12/57] ram_load: Factor out host_from_stream_offset call and check Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 13/57] migrate_init: Call from savevm Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 14/57] Rename save_live_complete to save_live_complete_precopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 15/57] Add Linux userfaultfd.h header Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 16/57] Return path: Open a return path on QEMUFile for sockets Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 17/57] Return path: socket_writev_buffer: Block even on non-blocking fd's Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 18/57] Migration commands Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 19/57] Return path: Control commands Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 20/57] Return path: Send responses from destination to source Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 21/57] migration_is_setup_or_active Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 22/57] Return path: Source handling of return path Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 23/57] Rework loadvm path for subloops Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 24/57] Add migration-capability boolean for postcopy-ram Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 25/57] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages Juan Quintela
2015-11-14 19:11 ` Stefan Weil
2015-11-16 10:07 ` Dr. David Alan Gilbert
2015-11-16 13:14 ` Stefan Weil
2015-11-16 14:20 ` Dr. David Alan Gilbert
2015-11-10 14:25 ` [Qemu-devel] [PULL 26/57] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 27/57] Modify save_live_pending for postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 28/57] postcopy: OS support test Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 29/57] migrate_start_postcopy: Command to trigger transition to postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 30/57] migration_completion: Take current state Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 31/57] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 32/57] Avoid sending vmdescription during postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 33/57] Add qemu_savevm_state_complete_postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 34/57] Postcopy: Maintain unsentmap Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 35/57] migration_completion: Take current state Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 36/57] postcopy: Incoming initialisation Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 37/57] postcopy: ram_enable_notify to switch on userfault Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 38/57] Postcopy: Postcopy startup in migration thread Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 39/57] Postcopy: End of iteration Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 40/57] Page request: Add MIG_RP_MSG_REQ_PAGES reverse command Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 41/57] Page request: Process incoming page request Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue Juan Quintela
2015-11-12 11:53 ` Peter Maydell
2015-11-12 12:04 ` Dr. David Alan Gilbert
2015-11-12 12:15 ` Peter Maydell
2015-11-12 12:23 ` Dr. David Alan Gilbert
2015-11-12 12:57 ` Peter Maydell
2015-11-12 13:08 ` Dr. David Alan Gilbert
2015-11-12 13:18 ` Peter Maydell
2015-11-12 13:53 ` Peter Maydell
2015-11-12 14:20 ` Dr. David Alan Gilbert
2015-11-12 15:25 ` Juan Quintela
2015-11-12 15:57 ` Dr. David Alan Gilbert
2015-11-12 14:22 ` Juan Quintela [this message]
2015-11-12 13:36 ` Markus Armbruster
2015-11-16 10:10 ` Andreas Färber
2015-11-10 14:25 ` [Qemu-devel] [PULL 43/57] postcopy_ram.c: place_page and helpers Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 44/57] Postcopy: Use helpers to map pages during migration Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 45/57] postcopy: Check order of received target pages Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 46/57] Don't sync dirty bitmaps in postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 47/57] Don't iterate on precopy-only devices during postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 48/57] Host page!=target page: Cleanup bitmaps Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 49/57] Round up RAMBlock sizes to host page sizes Juan Quintela
2015-12-30 0:26 ` Peter Crosthwaite
2016-01-04 9:48 ` Dr. David Alan Gilbert
2016-01-06 21:27 ` Paolo Bonzini
2015-11-10 14:25 ` [Qemu-devel] [PULL 50/57] Postcopy; Handle userfault requests Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 51/57] Start up a postcopy/listener thread ready for incoming page data Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 52/57] postcopy: Wire up loadvm_postcopy_handle_ commands Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 53/57] Postcopy: Mark nohugepage before discard Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 54/57] End of migration for postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 55/57] Disable mlock around incoming postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 56/57] Inhibit ballooning during postcopy Juan Quintela
2015-11-10 14:25 ` [Qemu-devel] [PULL 57/57] migration: qemu_savevm_state_cleanup becomes mandatory operation Juan Quintela
2015-11-10 22:21 ` [Qemu-devel] [PULL 00/57] Migration pull (take 2) Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2015-11-09 17:28 [Qemu-devel] [PULL 00/57] Migration pull Juan Quintela
2015-11-09 17:28 ` [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pozfqova.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).