From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode
Date: Thu, 15 Oct 2015 18:58:17 +0900 [thread overview]
Message-ID: <87pp0g5u86.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <1444900440.24283.18.camel@redhat.com> (Gerd Hoffmann's message of "Thu, 15 Oct 2015 11:14:00 +0200")
Gerd Hoffmann <kraxel@redhat.com> writes:
>> > Also you don't need a init function, you can simply init the array with
>> > c99 initializers:
>> >
>> > chtype vga_to_curses[256] = {
>> > [0x04] = ACS_DIAMOND,
>> > [ ... ]
>> > };
>>
>> This is not possible, because ACS_* is not constant (initialized by
>> reading from termcap or such).
>
> Ah, ok. That isn't obvious from reading the code. Can you add a
> comment please?
Oh, sent updated patch already. I will resend a updated patch to this
reply.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2015-10-15 9:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 11:35 [Qemu-devel] [RFC 0/3] improve/fix -curses mode OGAWA Hirofumi
2015-10-14 11:36 ` [Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors OGAWA Hirofumi
2015-10-14 11:37 ` [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode OGAWA Hirofumi
2015-10-14 11:37 ` [Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses OGAWA Hirofumi
2015-10-14 14:04 ` [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode Eric Blake
2015-10-14 15:44 ` Gerd Hoffmann
2015-10-14 23:58 ` OGAWA Hirofumi
2015-10-15 0:06 ` OGAWA Hirofumi
2015-10-15 0:07 ` [Qemu-devel] [PATCH v2 1/3] " OGAWA Hirofumi
2015-10-15 7:48 ` [Qemu-devel] [PATCH 2/3] " Gerd Hoffmann
2015-10-15 8:24 ` OGAWA Hirofumi
2015-10-15 8:50 ` OGAWA Hirofumi
2015-10-15 9:13 ` Gerd Hoffmann
2015-10-15 9:54 ` OGAWA Hirofumi
2015-10-15 9:54 ` [Qemu-devel] [PATCH v3] " OGAWA Hirofumi
2015-10-19 10:14 ` [Qemu-devel] [PATCH 2/3] " Gerd Hoffmann
2015-10-19 12:22 ` OGAWA Hirofumi
2015-10-15 9:14 ` Gerd Hoffmann
2015-10-15 9:58 ` OGAWA Hirofumi [this message]
2015-10-15 10:01 ` [Qemu-devel] [PATCH v4] " OGAWA Hirofumi
2015-10-14 16:46 ` [Qemu-devel] [RFC 0/3] improve/fix " Markus Armbruster
2015-10-14 23:59 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp0g5u86.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).