From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode
Date: Thu, 15 Oct 2015 09:06:12 +0900 [thread overview]
Message-ID: <87pp0h6lmz.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <87y4f56lzu.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of "Thu, 15 Oct 2015 08:58:29 +0900")
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> On Mi, 2015-10-14 at 20:37 +0900, OGAWA Hirofumi wrote:
>>> This converts vga code to curses code in console_write_bh().
>>>
>>> With this changes, we can see line graphics (for example, dialog uses)
>>> correctly.
>>
>> But it breaks line graphics in vga text mode on gtk I suspect?
>
> vga_to_curses[] is filled by curses_setup(). So if no -curses option, I
> think it should have no change to behavior. (BTW, there is no common
> section like kernel in qemu build, right? i.e. no need initializer to
> global value.)
The patch is following reply removes unnecessary
memset(vga_to_curses, 0, sizeof(vga_to_curses));
in curses_setup(). And tested line graphics works on both of gtk and curses.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2015-10-15 0:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 11:35 [Qemu-devel] [RFC 0/3] improve/fix -curses mode OGAWA Hirofumi
2015-10-14 11:36 ` [Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors OGAWA Hirofumi
2015-10-14 11:37 ` [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode OGAWA Hirofumi
2015-10-14 11:37 ` [Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses OGAWA Hirofumi
2015-10-14 14:04 ` [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode Eric Blake
2015-10-14 15:44 ` Gerd Hoffmann
2015-10-14 23:58 ` OGAWA Hirofumi
2015-10-15 0:06 ` OGAWA Hirofumi [this message]
2015-10-15 0:07 ` [Qemu-devel] [PATCH v2 1/3] " OGAWA Hirofumi
2015-10-15 7:48 ` [Qemu-devel] [PATCH 2/3] " Gerd Hoffmann
2015-10-15 8:24 ` OGAWA Hirofumi
2015-10-15 8:50 ` OGAWA Hirofumi
2015-10-15 9:13 ` Gerd Hoffmann
2015-10-15 9:54 ` OGAWA Hirofumi
2015-10-15 9:54 ` [Qemu-devel] [PATCH v3] " OGAWA Hirofumi
2015-10-19 10:14 ` [Qemu-devel] [PATCH 2/3] " Gerd Hoffmann
2015-10-19 12:22 ` OGAWA Hirofumi
2015-10-15 9:14 ` Gerd Hoffmann
2015-10-15 9:58 ` OGAWA Hirofumi
2015-10-15 10:01 ` [Qemu-devel] [PATCH v4] " OGAWA Hirofumi
2015-10-14 16:46 ` [Qemu-devel] [RFC 0/3] improve/fix " Markus Armbruster
2015-10-14 23:59 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp0h6lmz.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).