From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler
Date: Wed, 07 Oct 2015 14:20:28 +0530 [thread overview]
Message-ID: <87pp0r12qz.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20151006080914.GB19089@stefanha-thinkpad>
Stefan Hajnoczi <stefanha@gmail.com> writes:
> On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote:
>> If the user tries to hot unplug a virtio-9p device, it seems to succeed but
>> in fact:
>> - virtio-9p coroutines thread pool and async queue are leaked
>> - QEMU crashes in virtio_vmstate_change() if the user tries to live migrate
>>
>> This patch brings hot unplug support to virtio-9p-device. It fixes both
>> above issues.
>>
>> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
>> ---
>> hw/9pfs/virtio-9p-device.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>
> What happens to in-flight I/O requests? We cannot assume that the guest
> driver quiesces the device.
We enable migration blocker when we have an active mount. So if we get
here, that should indicate no active 9p mounts.
-aneesh
next prev parent reply other threads:[~2015-10-07 8:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 9:07 [Qemu-devel] [PATCH 0/3] virtio-9p: hotplug and migration support Greg Kurz
2015-10-05 9:07 ` [Qemu-devel] [PATCH 1/3] virtio-9p-coth: add release function and fix init error path Greg Kurz
2015-10-06 9:16 ` Greg Kurz
2015-10-05 9:07 ` [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler Greg Kurz
2015-10-06 8:09 ` Stefan Hajnoczi
2015-10-06 9:13 ` Greg Kurz
2015-10-07 8:50 ` Aneesh Kumar K.V [this message]
2015-10-09 7:23 ` Greg Kurz
2015-10-09 7:36 ` Michael S. Tsirkin
2015-10-09 10:54 ` Greg Kurz
2015-10-05 9:07 ` [Qemu-devel] [PATCH 3/3] virtio-9p: add savem handlers Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp0r12qz.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).