From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjkRg-0002v8-MW for qemu-devel@nongnu.org; Wed, 07 Oct 2015 04:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjkRc-00066Y-KR for qemu-devel@nongnu.org; Wed, 07 Oct 2015 04:51:32 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:44779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjkRc-00065n-1k for qemu-devel@nongnu.org; Wed, 07 Oct 2015 04:51:28 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Oct 2015 18:51:24 +1000 Received: from d23relay10.au.ibm.com (d23relay10.au.ibm.com [9.190.26.77]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 25FF73578052 for ; Wed, 7 Oct 2015 19:51:22 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t978pCd563897728 for ; Wed, 7 Oct 2015 19:51:21 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t978omAi030647 for ; Wed, 7 Oct 2015 19:50:48 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <20151006080914.GB19089@stefanha-thinkpad> References: <20151005090710.20420.26941.stgit@bahia.huguette.org> <20151005090722.20420.71571.stgit@bahia.huguette.org> <20151006080914.GB19089@stefanha-thinkpad> Date: Wed, 07 Oct 2015 14:20:28 +0530 Message-ID: <87pp0r12qz.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Greg Kurz Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" Stefan Hajnoczi writes: > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: >> If the user tries to hot unplug a virtio-9p device, it seems to succeed but >> in fact: >> - virtio-9p coroutines thread pool and async queue are leaked >> - QEMU crashes in virtio_vmstate_change() if the user tries to live migrate >> >> This patch brings hot unplug support to virtio-9p-device. It fixes both >> above issues. >> >> Signed-off-by: Greg Kurz >> --- >> hw/9pfs/virtio-9p-device.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > What happens to in-flight I/O requests? We cannot assume that the guest > driver quiesces the device. We enable migration blocker when we have an active mount. So if we get here, that should indicate no active 9p mounts. -aneesh