From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Victor Kaplansky <victork@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are stored.
Date: Thu, 06 Aug 2015 16:55:41 +0100 [thread overview]
Message-ID: <87pp30jts2.fsf@linaro.org> (raw)
In-Reply-To: <20150806115950-mutt-send-email-mst@redhat.com>
Michael S. Tsirkin <mst@redhat.com> writes:
> On Thu, Aug 06, 2015 at 09:57:03AM +0100, Alex Bennée wrote:
>>
>> Victor Kaplansky <victork@redhat.com> writes:
>>
<snip>
>> >
>> > As a hack, we also touch two sources for generated *.hex files. This is
>> > to ensure *.hex rebuild, when old revision is switched to the new one.
>>
>> While I'm sure this was useful for testing do we really want to include
>> such a hack in the git history?
>
> This is the hint for why it's needed there:
> "This is to ensure *.hex rebuild, when old revision is switched to the
> new one."
> Maybe add this, making this more explicit:
> Without this hack, anyone doing "git pull; make" will not get *.hex rebuilt
> correctly since the dependency file would be missing.
Ahh that makes more sense :-)
--
Alex Bennée
next prev parent reply other threads:[~2015-08-06 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 17:27 [Qemu-devel] [PATCH v2 0/2] make: Cleanup and fix of loading of dependency info Victor Kaplansky
2015-08-05 17:28 ` [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are stored Victor Kaplansky
2015-08-06 8:57 ` Alex Bennée
2015-08-06 9:02 ` Michael S. Tsirkin
2015-08-06 15:55 ` Alex Bennée [this message]
2015-08-05 17:29 ` [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files Victor Kaplansky
2015-08-05 17:40 ` Paolo Bonzini
2015-08-05 18:22 ` Victor kaplansky
2015-08-06 7:05 ` Markus Armbruster
2015-08-05 18:32 ` Michael S. Tsirkin
2015-08-05 18:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp30jts2.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=victork@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).