From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZNNWH-0000l7-UA
	for qemu-devel@nongnu.org; Thu, 06 Aug 2015 11:55:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZNNWE-0000At-Ns
	for qemu-devel@nongnu.org; Thu, 06 Aug 2015 11:55:49 -0400
Received: from mail-wi0-f176.google.com ([209.85.212.176]:34335)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZNNWE-0000AQ-BJ
	for qemu-devel@nongnu.org; Thu, 06 Aug 2015 11:55:46 -0400
Received: by wicne3 with SMTP id ne3so28288454wic.1
	for <qemu-devel@nongnu.org>; Thu, 06 Aug 2015 08:55:45 -0700 (PDT)
References: <1438795570-3930-1-git-send-email-victork@redhat.com>
	<1438795570-3930-2-git-send-email-victork@redhat.com>
	<87vbcskd5s.fsf@linaro.org>
	<20150806115950-mutt-send-email-mst@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <20150806115950-mutt-send-email-mst@redhat.com>
Date: Thu, 06 Aug 2015 16:55:41 +0100
Message-ID: <87pp30jts2.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are
	stored.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Victor Kaplansky <victork@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Richard Henderson <rth@twiddle.net>


Michael S. Tsirkin <mst@redhat.com> writes:

> On Thu, Aug 06, 2015 at 09:57:03AM +0100, Alex Bennée wrote:
>> 
>> Victor Kaplansky <victork@redhat.com> writes:
>> 
<snip>
>> >
>> > As a hack, we also touch two sources for generated *.hex files. This is
>> > to ensure *.hex rebuild, when old revision is switched to the new one.
>> 
>> While I'm sure this was useful for testing do we really want to include
>> such a hack in the git history?
>
> This is the hint for why it's needed there:
> "This is to ensure *.hex rebuild, when old revision is switched to the
> new one."
> Maybe add this, making this more explicit:
> 	Without this hack, anyone doing "git pull; make" will not get *.hex rebuilt
> 	correctly since the dependency file would be missing.

Ahh that makes more sense :-)

-- 
Alex Bennée