From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yps9N-00059n-1m for qemu-devel@nongnu.org; Wed, 06 May 2015 01:45:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yps9I-0006sp-Qs for qemu-devel@nongnu.org; Wed, 06 May 2015 01:45:40 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:34924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yps9I-0006sE-2h for qemu-devel@nongnu.org; Wed, 06 May 2015 01:45:36 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 May 2015 15:45:33 +1000 From: Nikunj A Dadhania In-Reply-To: <20150505162833.3d0141e2@thh440s> References: <1430816036-26408-1-git-send-email-nikunj@linux.vnet.ibm.com> <1430816036-26408-3-git-send-email-nikunj@linux.vnet.ibm.com> <20150505162833.3d0141e2@thh440s> Date: Wed, 06 May 2015 11:14:32 +0530 Message-ID: <87pp6ejm4f.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 2/6] spapr_pci: encode missing 64-bit memory address space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Thomas Huth writes: > On Tue, 5 May 2015 14:23:52 +0530 > Nikunj A Dadhania wrote: > >> The properties reg/assigned-resources need to encode 64-bit memory >> address space as part of phys.hi dword. >> >> 00 if configuration space >> 01 if IO region, >> 10 if 32-bit MEM region >> 11 if 64-bit MEM region >> >> Signed-off-by: Nikunj A Dadhania >> --- >> hw/ppc/spapr_pci.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c >> index 4df3a33..ea1a092 100644 >> --- a/hw/ppc/spapr_pci.c >> +++ b/hw/ppc/spapr_pci.c >> @@ -786,7 +786,13 @@ typedef struct ResourceProps { >> * phys.hi = 0xYYXXXXZZ, where: >> * 0xYY = npt000ss >> * ||| | >> - * ||| +-- space code: 1 if IO region, 2 if MEM region >> + * ||| +-- space code >> + * ||| | >> + * ||| + 00 if configuration space >> + * ||| + 01 if IO region, >> + * ||| + 10 if 32-bit MEM region >> + * ||| + 11 if 64-bit MEM region >> + * ||| >> * ||+------ for non-relocatable IO: 1 if aliased >> * || for relocatable IO: 1 if below 64KB >> * || for MEM: 1 if below 1MB >> @@ -846,6 +852,8 @@ static void populate_resource_props(PCIDevice *d, ResourceProps *rp) >> reg->phys_hi = cpu_to_be32(dev_id | b_rrrrrrrr(pci_bar(d, i))); >> if (d->io_regions[i].type & PCI_BASE_ADDRESS_SPACE_IO) { >> reg->phys_hi |= cpu_to_be32(b_ss(1)); >> + } else if (d->io_regions[i].type & PCI_BASE_ADDRESS_MEM_TYPE_64) { >> + reg->phys_hi |= cpu_to_be32(b_ss(3)); >> } else { >> reg->phys_hi |= cpu_to_be32(b_ss(2)); >> } > > Reviewed-by: Thomas Huth > > BTW, does this also require the new version of SLOF already? Not yet, only after patch 4/6 newer SLOF would be needed. This fixes the hotplug case for device requesting 64-bit bars, like nec-usb-xhci. Regards, Nikunj