From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WW0en-0000JK-VP
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 05:43:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WW0ei-0007kv-QL
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 05:43:29 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1396543778-22307-13-git-send-email-mst@redhat.com> (Michael
	S. Tsirkin's message of "Thu, 3 Apr 2014 19:51:42 +0300")
References: <1396543778-22307-1-git-send-email-mst@redhat.com>
	<1396543778-22307-13-git-send-email-mst@redhat.com>
Date: Fri, 04 Apr 2014 11:43:16 +0200
Message-ID: <87ppkx8m6j.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v5 12/24] vmstate: fix buffer overflow in
	target-arm/machine.c
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, qemu-stable@nongnu.org, Alexey Kardashevskiy <aik@ozlabs.ru>, Anthony Liguori <anthony@codemonkey.ws>, Amit Shah <amit.shah@redhat.com>, dgilbert@redhat.com

"Michael S. Tsirkin" <mst@redhat.com> wrote:
> CVE-2013-4531
>
> cpreg_vmstate_indexes is a VARRAY_INT32. A negative value for
> cpreg_vmstate_array_len will cause a buffer overflow.
>
> VMSTATE_INT32_LE was supposed to protect against this
> but doesn't because it doesn't validate that input is
> non-negative.
>
> Fix this macro to valide the value appropriately.
>
> The only other user of VMSTATE_INT32_LE doesn't
> ever use negative numbers so it doesn't care.
>
> Reported-by: Anthony Liguori <anthony@codemonkey.ws>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Integrated.