From: Juan Quintela <quintela@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Amit Shah <amit.shah@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] migration: add more traces
Date: Mon, 10 Mar 2014 23:42:14 +0100 [thread overview]
Message-ID: <87ppltfzg9.fsf@elfo.mitica> (raw)
In-Reply-To: <531E3E22.3090700@ozlabs.ru> (Alexey Kardashevskiy's message of "Tue, 11 Mar 2014 09:35:14 +1100")
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> On 03/11/2014 04:17 AM, Amit Shah wrote:
>> On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote:
>>> This replaces DPRINTF macro with tracepoints.
>>>
>>> This moves some messages from migration.c to savevm.c.
>>>
>>> This adds tracepoint to signal about fileds failed to migrate.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>>
>>> This is v3. Should I repost the whole thing or just "3/3 v3" is ok? Thanks!
>>
>> This broke the build on windows:
>>
>> http://news.gmane.org/find-root.php?message_id=CAFEAcA%5fEa72JTVLJ3Z%2dzUtoe8vg%2bjh8R96mNW2c2x2Mx%5fj%2bFwg%40mail.gmail.com
>>
>> Please fix.
>
> I am sorry but how? Is it msvc? Is it mingw? Or replace with
> %02x:%02x:%02x:%02x:%02x:%02x?
mingw32.
Replace with %02x:02x or create a
qmeu_ether_ntoa() function with exactly that code in
utils/cutils.c
Later, Juan.
next prev parent reply other threads:[~2014-03-10 22:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 4:10 [Qemu-devel] [PATCH v2 0/3] migration: add more traces Alexey Kardashevskiy
2014-03-04 4:10 ` [Qemu-devel] [PATCH v2 1/3] vl: add system_wakeup_request tracepoint Alexey Kardashevskiy
2014-03-04 4:10 ` [Qemu-devel] [PATCH v2 2/3] migration: extend section_start/end traces Alexey Kardashevskiy
2014-03-04 4:10 ` [Qemu-devel] [PATCH v2 3/3] migration: add more traces Alexey Kardashevskiy
2014-03-04 12:26 ` Paolo Bonzini
2014-03-04 15:14 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
2014-03-06 20:04 ` Amit Shah
2014-03-10 17:17 ` Amit Shah
2014-03-10 22:35 ` Alexey Kardashevskiy
2014-03-10 22:42 ` Juan Quintela [this message]
2014-03-04 12:32 ` [Qemu-devel] [PATCH v2 0/3] " Paolo Bonzini
2014-03-05 9:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppltfzg9.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=aik@ozlabs.ru \
--cc=amit.shah@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).