From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48225)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WN8ts-0001WL-Ct
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 18:42:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WN8tn-0004q6-Rp
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 18:42:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64395)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WN8tn-0004pq-KL
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 18:42:19 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <531E3E22.3090700@ozlabs.ru> (Alexey Kardashevskiy's message of
	"Tue, 11 Mar 2014 09:35:14 +1100")
References: <5315C65F.6040103@redhat.com>
	<1393946096-27403-1-git-send-email-aik@ozlabs.ru>
	<20140310171729.GC11308@grmbl.mre> <531E3E22.3090700@ozlabs.ru>
Date: Mon, 10 Mar 2014 23:42:14 +0100
Message-ID: <87ppltfzg9.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3] migration: add more traces
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> On 03/11/2014 04:17 AM, Amit Shah wrote:
>> On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote:
>>> This replaces DPRINTF macro with tracepoints.
>>>
>>> This moves some messages from migration.c to savevm.c.
>>>
>>> This adds tracepoint to signal about fileds failed to migrate.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>>
>>> This is v3. Should I repost the whole thing or just "3/3 v3" is ok? Thanks!
>> 
>> This broke the build on windows:
>> 
>> http://news.gmane.org/find-root.php?message_id=CAFEAcA%5fEa72JTVLJ3Z%2dzUtoe8vg%2bjh8R96mNW2c2x2Mx%5fj%2bFwg%40mail.gmail.com
>> 
>> Please fix.
>
> I am sorry but how? Is it msvc? Is it mingw? Or replace with
> %02x:%02x:%02x:%02x:%02x:%02x?

mingw32.

Replace with %02x:02x or create a

qmeu_ether_ntoa()  function with exactly that code in

utils/cutils.c


Later, Juan.