From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vpyzw-0005I9-Ha for qemu-devel@nongnu.org; Mon, 09 Dec 2013 06:27:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vpyzo-0004QW-Au for qemu-devel@nongnu.org; Mon, 09 Dec 2013 06:27:36 -0500 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:49951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vpyzl-0004Od-Ot for qemu-devel@nongnu.org; Mon, 09 Dec 2013 06:27:28 -0500 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Dec 2013 16:57:01 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id D0D611258051 for ; Mon, 9 Dec 2013 16:58:05 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rB9BQtAq54460500 for ; Mon, 9 Dec 2013 16:56:55 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rB9BQu5f008037 for ; Mon, 9 Dec 2013 16:56:56 +0530 From: "Aneesh Kumar K.V" In-Reply-To: <20131209102517.33F4EE0090@blue.fi.intel.com> References: <1385726178-10201-1-git-send-email-kirill.shutemov@linux.intel.com> <20131209102517.33F4EE0090@blue.fi.intel.com> Date: Mon, 09 Dec 2013 16:56:55 +0530 Message-ID: <87ppp6b6yo.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" "Kirill A. Shutemov" Cc: qemu-devel@nongnu.org, aliguori@amazon.com "Kirill A. Shutemov" writes: > Kirill A. Shutemov wrote: >> Currently we have few issues with P9_STATS_GEN: >> >> - We don't try to read st_gen anything except files or directories, but >> still set P9_STATS_GEN bit in st_result_mask. It may mislead client: >> we present garbage as valid st_gen. >> >> - If we failed to get valid st_gen with ENOTTY, we ignore error, but >> still set P9_STATS_GEN bit in st_result_mask. >> >> - If we failed to get valid st_gen with any other errno, we fail >> getattr altogether. It's excessive: we block valid client use-cases, >> like chdir(2) to non-readable directory with execution bit set. >> >> The patch fixes these issues and cleanup code a bit. >> >> Signed-off-by: Kirill A. Shutemov >> Reviewed-by: Daniel P. Berrange >> Reviewed-by: Aneesh Kumar K.V > > Ping? > I am hoping that this will go to upstream directly without me doing a pull request ? Anthony, let me know if this need anything to be done from my side -aneesh