From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1V2LaS-0007Kn-FA
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:28:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1V2LaR-000553-8E
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:28:08 -0400
Received: from mail-oa0-f43.google.com ([209.85.219.43]:52110)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1V2LaR-00054z-3t
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:28:07 -0400
Received: by mail-oa0-f43.google.com with SMTP id i7so4300061oag.16
	for <qemu-devel@nongnu.org>; Thu, 25 Jul 2013 06:28:06 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <87ehan8hhn.fsf@rustcorp.com.au>
References: <87li4v8ktz.fsf@rustcorp.com.au>
	<CA+aC4ksBr62tX1aiAXnVueixgyvgFu5uq17TEiD8sZRKD_Tp3w@mail.gmail.com>
	<87ehan8hhn.fsf@rustcorp.com.au>
Date: Thu, 25 Jul 2013 08:28:00 -0500
Message-ID: <87ppu66a73.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] vhost acceleration broken?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

Rusty Russell <rusty@rustcorp.com.au> writes:

> Anthony Liguori <anthony@codemonkey.ws> writes:
>> On Wed, Jul 24, 2013 at 8:55 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>>> Hi all,
>>>
>>>         Using latest kernel and master qemu, the following doesn't use
>>> vhost acceleration:
>>>
>>> sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost=on -net nic,model=virtio -drive file=$QEMUIMAGE,index=0,media=disk,if=virtio -kernel arch/x86/boot/bzImage -append "root=/dev/vda1 $KARGS $*"
>>
>> sudo qemu-system-x86_64 -enable-kvm $ARGS -m 1G -netdev
>> tap,script=/home/rusty/bin/kvm-ifup,vhost=on,id=net0 -device
>> virtio-net-pci,netdev=net0 -drive file=$QEMUIMAGE,if=virtio -kernel
>> arch/x86/boot/bzImage -append "root=/dev/vda1 $KARGS $*"
>>
>> We really ought to strongly deprecate -net because it's misleading.  I
>> suspect we can reasonably add a warning for model=virtio saying
>> "please don't use this" and eventually remove it entirely.
>
> Thankyou, that works.
>
> I'm sure you've thought more deeply about the qemu cmdline than I have,
> so I won't comment.

Any comment you would make is certainly fair.

We have a pretty awful legacy command line set that comes from years of
half-baked concepts and the years when too many people just committed
random shit to the tree.

I think we probably need to start planning for a clean break.  Maybe
that's a good target for a 2.0 version...

Regards,

Anthony Liguori

>
> Cheers,
> Rusty.