From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upk4h-00084O-Pd for qemu-devel@nongnu.org; Thu, 20 Jun 2013 14:59:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Upk4e-00057n-3H for qemu-devel@nongnu.org; Thu, 20 Jun 2013 14:59:15 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:44437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upk4e-00057Z-05 for qemu-devel@nongnu.org; Thu, 20 Jun 2013 14:59:12 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Jun 2013 14:59:10 -0400 From: Anthony Liguori In-Reply-To: References: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> <1371674435-14973-3-git-send-email-aliguori@us.ibm.com> <51C31DD1.2030603@suse.de> <8738sc23h7.fsf@codemonkey.ws> Date: Thu, 20 Jun 2013 13:58:55 -0500 Message-ID: <87ppvgbocw.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/12] qtest: add spapr hypercall support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Alexey Kardashevskiy , Paul Mackerras , "qemu-ppc@nongnu.org" , Andreas =?utf-8?Q?F=C3=A4rber?= , "qemu-devel@nongnu.org" Alexander Graf writes: > Am 20.06.2013 um 17:42 schrieb Anthony Liguori : > >> Andreas F=C3=A4rber writes: >>=20 >>> Am 19.06.2013 22:40, schrieb Anthony Liguori: >>>> Signed-off-by: Anthony Liguori >>>> --- >>>> qtest.c | 29 +++++++++++++++++++++++++++++ >>>> tests/libqtest.c | 18 ++++++++++++++++++ >>>> tests/libqtest.h | 46 ++++++++++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 93 insertions(+) >>>>=20 >>>> diff --git a/qtest.c b/qtest.c >>>> index 07a9612..f8c8f44 100644 >>>> --- a/qtest.c >>>> +++ b/qtest.c >>>> @@ -19,6 +19,9 @@ >>>> #include "hw/irq.h" >>>> #include "sysemu/sysemu.h" >>>> #include "sysemu/cpus.h" >>>> +#ifdef TARGET_PPC64 >>>> +#include "hw/ppc/spapr.h" >>>> +#endif >>>>=20 >>>> #define MAX_IRQ 256 >>>>=20 >>>> @@ -141,6 +144,13 @@ static bool qtest_opened; >>>> * where NUM is an IRQ number. For the PC, interrupts can be intercep= ted >>>> * simply with "irq_intercept_in ioapic" (note that IRQ0 comes out with >>>> * NUM=3D0 even though it is remapped to GSI 2). >>>> + * >>>> + * Platform specific (sPAPR): >>>> + * >>>> + * > papr_hypercall NR ARG0 ARG1 ... ARG8 >>>=20 >>> The functions are called spapr_hcall*() but the protocol uses >>> papr_hypercall? >>=20 >> The discrepancy is inherited in the KVM vs. QEMU interfaces. It's >> called papr_hypercall in the KVM interface vs. spapr in QEMU. >>=20 >> I honestly don't know what the distinction between spapr and papr is. > > PAPR is what PAPR calls itself. However, there is also an ePAPR for > BookE, so in order to distinguish the 2 more easily, we named the > server version spapr wherever we remembered to. So does it make sense to have papr_hypercall()? Do hypercalls exist with the virtualization extensions on BookE? Regards, Anthony Liguori > > > Alex